[TVMScript] Do not throw error for duplicate definitions - #16811
Merged
Lunderberg merged 1 commit intoApr 3, 2024
Merged
Conversation
TVM's IR dialects require single-site assignment. However, the printer is different from most utilities, as it may neither assume that its input is well-formed, nor may it throw an exception if the input is ill-formed. The printer is often used for debugging, where logging and printouts of an IRModule are essential. In these cases, throwing an error would prevent a developer from determining why an IRModule is ill-formed.
Lunderberg
force-pushed
the
tvmscript_printer_must_handle_non_ssa
branch
from
March 29, 2024 12:55
139b923 to
d56237b
Compare
slyubomirsky
approved these changes
Apr 2, 2024
slyubomirsky
left a comment
slyubomirsky
left a comment
Contributor
There was a problem hiding this comment.
Good idea and good point about treating the printer as a debugging tool, though I think logging a warning or some kind of indication that something is wrong would be useful to add.
Contributor
Author
|
I went back and forth on it, as the existing |
Contributor
|
Glad to hear there's a plan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TVM's IR dialects require single-site assignment. However, the printer is different from most utilities, as it is often used for debugging when runtime assumptions are violated. Therefore, it may neither assume that its input is well-formed, nor may it throw an exception if the input is ill-formed, and must print an accurate representation of the underlying IR for use in debugging. When debugging, being unable to print an ill-formed
IRModuleprevents a developer from determining why the IRModule is ill-formed.