[Draft] Revert " [FFI] Re-introduce the boxed primitive values (#17257)" - #17272
Closed
Lunderberg wants to merge 1 commit into
Closed
[Draft] Revert " [FFI] Re-introduce the boxed primitive values (#17257)"#17272Lunderberg wants to merge 1 commit into
Lunderberg wants to merge 1 commit into
Conversation
This reverts commit `02f48828e4b56995be0021c9a98e1705a837e712`. The post-merge builds on `main` are failing in CI on both MacOS and Windows. The failure modes do not appear to be caused by the FFI changes, but the FFI changes impact enough parts of TVM that it's difficult to say that definitively.
Contributor
Author
|
If the CI fails in the "CI / MacOS" and "CI / Windows" builds, that will indicate that the current build failures on main are unrelated to the changes in #17257. |
Contributor
Author
|
The CI for this PR fails with the same errors as seen on main (copied below), so the FFI changes are unrelated to the build failures. Closing this PR, as it is not necessary to revert the FFI changes. For the MacOS build: For the Windows build: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit
02f48828e4b56995be0021c9a98e1705a837e712. The post-merge builds onmainare failing in CI on both MacOS and Windows. The failure modes do not appear to be caused by the FFI changes, but the FFI changes impact enough parts of TVM that it's difficult to say that definitively.