[Relax][VM] Improve diagnostics for unlowered Relax operators#19899
Draft
Kevin-Li-2025 wants to merge 1 commit into
Draft
[Relax][VM] Improve diagnostics for unlowered Relax operators#19899Kevin-Li-2025 wants to merge 1 commit into
Kevin-Li-2025 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves the error messages in CodeGenVM and CodeGenVMTIR when encountering an unlowered Relax operator, providing clearer guidance on how to resolve the issue and printing the offending call. A unit test has also been added to verify this error behavior. There are no review comments, so I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This improves the diagnostics emitted when VM codegen sees a normal Relax operator that was not lowered before codegen.
relax.nn.conv2d_transposelayout so the diagnostic exposes the layout attributes.Why
Issue #19694 reports that unsupported
conv{1,2,3}d_transposeattributes can pass through legalization and later fail with an opaque VM codegen error:Recent upstream work added dilation support, while the layout/out-layout passthrough remains useful for external codegen flows. This PR keeps that legalization behavior unchanged, but makes the eventual VM codegen failure actionable by showing the exact unlowered call and attributes.
Validation
git diff --checkPYTHONDONTWRITEBYTECODE=1 /Users/yinxiaogou/.cache/codex-runtimes/codex-primary-runtime/dependencies/python/bin/python3 -m py_compile tests/python/relax/test_transform_legalize_ops_nn.py tests/python/relax/test_vm_build.pyNot run locally: the targeted pytest, because this checkout does not have a built/importable TVM package available. CI should validate the new VM build test.
Helps #19694.