[Relay] Unifier hotfix - #2437

Merged

tqchen merged 55 commits into

apache:masterfrom

slyubomirsky:type-unifier

Jan 16, 2019

Commits on Jan 15, 2019

Expand unification in type solver
slyubomirsky
committed
862825a
Only register child type relations for incomplete child types
slyubomirsky
committed
c60e4c8
Removed redundant registrations
slyubomirsky
committed
318d85f
Be sure to copy linked list nodes for child types
slyubomirsky
committed
5155426
Add unifier tests
slyubomirsky
committed
94c5d97
Add a negative test case
slyubomirsky
committed
2bad1af
Check for recursive equalities when unifying
slyubomirsky
committed
0175c53
Minor tweaks to error messages
slyubomirsky
committed
6f5db7c
Improve recursive unification test
slyubomirsky
committed
16de70d
Do not copy relation list nodes if already resolved
slyubomirsky
committed
8829afe
Add visitor for type resolution, have more complicated unification test case
slyubomirsky
committed
5027d76
Avoid catastrophic failure in Resolve() by only recursing in one branch (not sure why this fails)
slyubomirsky
committed
ce59f5b
Add a null check before resolution
slyubomirsky
committed
4d1bde6
Move null check into resolution visitor
slyubomirsky
committed
c44bb73
Rename RecurrenceChecker to OccursChecker
slyubomirsky
committed
2b18e21
Recursively propagate type relations to child types when a constraint is added, not during unification. Resolve before running a relation
slyubomirsky
committed
beb2bb5
Make use of new unification in type inference, add generalization, fix broken tests
slyubomirsky
committed
36ae3f8
Intermediate progress on fixing the unifier (this breaks stuff)
slyubomirsky
committed
5f35576
Generalize only after all other type unification (still broken)
slyubomirsky
committed
db247ad
Correct error in type var instantiation
slyubomirsky
committed
599d4a6
Do not permit free type variables in tests
slyubomirsky
committed
600d024
Remove commented-out function inference code
slyubomirsky
committed
face113
Instantiate generalizer once in type inference
slyubomirsky
committed
aa9c837
Fix error in type inference cpp test
slyubomirsky
committed
59eabc7
Use alpha equality in cpp test
slyubomirsky
committed
32240e0
Use free var pass for collecting type params in generalization. Fix double-counting bug in free var pass
slyubomirsky
committed
a7e6fa6
Handle recursion in let, generalize early in that case
slyubomirsky
committed
299574d
Fix FreeVar pass doc
slyubomirsky
committed
0dcd205
Refactoring of free var visitors to ensure fixed order (mostly @jroesch's work)
slyubomirsky
committed
ebf9688
Add tests for various variable collection passes, add Python handles for passes, fix bug in all vars pass
slyubomirsky
committed
6b15cf7
Unifier should not keep additional state, ensure that type params *match* in func types
slyubomirsky
committed
6ae595a
Attempt at keeping type env in inferencer (broken)
slyubomirsky
committed
13ecb53
Revert "Attempt at keeping type env in inferencer (broken)"
slyubomirsky
committed
6cb0ba2
Revert "Unifier should not keep additional state, ensure that type params *match* in func types"
slyubomirsky
committed
c2088f3
Remove generalization and tests related to it for now; it needs to be redesigned
slyubomirsky
committed
8ac6570
Rename method Bounded() to MarkBounded()
slyubomirsky
committed
b4dec40
Require all type args to be specified or none (however, type arg test broken without generalization)
slyubomirsky
committed
b00eb4f
Whitespace
slyubomirsky
committed
1eb81e4
Remove redundant func type creation in instantiation in TypeSolver
slyubomirsky
committed
11bda1c
Style change (variable rename)
slyubomirsky
committed
02824df
Instantiate type vars in type_infer instead of unifier, do not expose unifier
slyubomirsky
committed
f7c14e8
Whitespace fixes and redundant check
slyubomirsky
committed
19aa3c2
Simplify function literal type inference case
slyubomirsky
committed
b697a59
Style nitpick
slyubomirsky
committed
fa4f548
Don't drop type params in unifier
slyubomirsky
committed
af32ff4
Clean up and better document type var instantiation hack
slyubomirsky
committed
755611a
MergeFromTo gathers rel links recursively
slyubomirsky
committed
a4f5c09
Copy links over to avoid circular links
slyubomirsky
committed
1ee69cc
Use set for storing rels, propagate after merging typenodes
slyubomirsky
committed
8cf9962
Propagator should be able to propagate multiple relations at once
slyubomirsky
committed
0f9d580
Correct description of AllVars() utility
slyubomirsky
committed
eb2754d
Ensure null annotations replaced in AD
slyubomirsky
committed
02e1f1c
Unnecessary check
slyubomirsky
committed
96e4ebb

Commits on Jan 16, 2019

Leave grad ret type to be inferred iannotations gone
slyubomirsky
committed
7c1a42f
lint
slyubomirsky
committed
c02375c