ZOOKEEPER-5080: Fix flaky metric assertion in SnapshotAndRestoreCommandTest - #2442
Merged
Conversation
…ndTest Time.currentElapsedTime counts whole milliseconds, so a snapshot of the ten znodes this test creates can finish before the clock moves and leave avg_snapshottime at 0.0 on a fast runner. Assert cnt_snapshottime instead, and the same for avg_restore_time.
uros-b
approved these changes
Aug 24, 2026
Member
|
+1, LGTM |
anmolnar
approved these changes
Aug 25, 2026
asf-gitbox-commits
pushed a commit
that referenced
this pull request
Aug 25, 2026
…ndTest Reviewers: uros-b, anmolnar Author: IvanKhanas Closes #2442 from IvanKhanas/ZOOKEEPER-5080 (cherry picked from commit b1d1f47) Signed-off-by: Andor Molnar <andor@cloudera.com>
Contributor
|
Merged to master and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time.currentElapsedTime counts whole milliseconds, so a snapshot of the ten
znodes this test creates can finish before the clock moves and leave
avg_snapshottime at 0.0 on a fast runner. Assert cnt_snapshottime instead, and
the same for avg_restore_time.