Repository navigation
List SimulatorFrameworkBridge's sources instead of its directory - #20
Merged
Merged
Conversation
rubu
force-pushed
the
sync/01-xcodegen-sources
branch
from
October 8, 2026 19:51
3d159e2 to
5824a81
Compare
rubu
marked this pull request as ready for review
October 9, 2026 07:48
mrvissercb
self-requested a review
October 9, 2026 18:39
mrvissercb
approved these changes
Oct 9, 2026
| SimulatorFrameworkBridge-iOS: | ||
| templates: [Guest] | ||
| platform: iOS | ||
| # Listed rather than `.`: XcodeGen 2.46 puts a spec-directory source's subgroups in two groups, |
Collaborator
There was a problem hiding this comment.
🤖 thought: Once XcodeGen ships #1652, is there a ticket so we remember to switch both targets back to path: .?
Collaborator
There was a problem hiding this comment.
👨 let's just maybe carry #1652 as a comment reference in the code to track for the next time we're here?
| - path: Swift | ||
| - path: SimulatorFrameworkBridge.swift | ||
| - path: SimulatorFrameworkBridge-Bridging-Header.h | ||
| - path: Privacy.md |
Collaborator
There was a problem hiding this comment.
🤖 question: New top-level files under SimulatorFrameworkBridge will need to be added to both target lists by hand. Is that fine until the XcodeGen fix lands?
Author
There was a problem hiding this comment.
Yeah, I think we are in a spot were we won't need any extra syncs, so we could delay the next one until the XcodeGen fix lands.
rubu
force-pushed
the
sync/01-xcodegen-sources
branch
from
October 12, 2026 20:29
5824a81 to
0b1bc2b
Compare
XcodeGen 2.46 puts a spec-directory source's subgroups in two groups, which Xcode 27.2 refuses to open (yonaskolb/XcodeGen#1651). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Upstream exposes eject over gRPC and sends it as a Consumer usage, which the Indigo transport has no equivalent for. Eject now carries the legacy soft keyboard source as well, so Indigo delivers it too; iOS toggles the software keyboard on it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rubu
force-pushed
the
sync/01-xcodegen-sources
branch
from
October 13, 2026 14:36
0b1bc2b to
514ec5a
Compare
Mirrors how simctl forwards them, which is how the Appetize simulator hooks get their DYLD_INSERT_LIBRARIES. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
A client names a POSIX shared-memory region and the display's current frame is copied into it. The request carries the buffer, so a copy is answered when it is asked for rather than on the next rendered frame, which a still display would never produce and a screenshot could never wait out. A client can attach before the display has rendered, which is what boot verification does, so a request arriving with no surface yet waits for the first one instead of failing. Waiters are released when the display tears down, so none outlives the stream. The scale factor is fixed by the first request that names one, so the geometry a client probed stays true for every frame after it. Rows are copied packed, dropping the surface's row padding, and only 4-channel, 8-bit surfaces are copied. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XcodeGen 2.46 puts the subgroups of a spec-directory source (
path: .) in two groups, and Xcode 27.2 refuses to open the generatedSimulatorFrameworkBridge.xcodeproj("The reference "Runtime" is a member of more than one group"). Listing the bridge's sources explicitly avoids it (yonaskolb/XcodeGen#1651, fix pending in #1652).Only builds with Xcode 27.2 need it; CI builds with the runner's Xcode 26, which opens the project either way. It can be reverted once a released XcodeGen includes #1652.
First of the stack onto
sync/upstream-2026-10, a mirror of facebook/idb atf0342d65(2026-10-12).🤖 Generated with Claude Code