Deploy service-vault as its own HelmRelease with kubevault bundled - #1327
Merged
Merged
Conversation
ArnobKumarSaha
force-pushed
the
master
branch
2 times, most recently
from
September 3, 2026 04:20
cc445c3 to
b38cc0e
Compare
ArnobKumarSaha
force-pushed
the
arnob-vault-relay
branch
6 times, most recently
from
September 14, 2026 09:33
8fe8d26 to
44f7b7b
Compare
ArnobKumarSaha
force-pushed
the
arnob-vault-relay
branch
from
September 14, 2026 10:22
44f7b7b to
d801bc8
Compare
ace-installer creates the service-vault release directly and the ace HelmRelease depends on it, instead of shipping service-vault as an ace subchart. The chart now pulls in the kubevault operator as a subchart, mirroring how service-gateway pulls in voyager-gateway. Signed-off-by: Arnob kumar saha <arnob@appscode.com>
ArnobKumarSaha
force-pushed
the
arnob-vault-relay
branch
from
September 14, 2026 10:44
d801bc8 to
4e1aede
Compare
ArnobKumarSaha
added a commit
that referenced
this pull request
Sep 14, 2026
…1327) Signed-off-by: Arnob kumar saha <arnob@appscode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ships a relay-enabled
VaultServerand installs it as a first-class platform release:ace-installercreates theservice-vaultHelmRelease itself and theacerelease depends on it, rather than carryingservice-vaultas anacesubchart. The chart bundles the KubeVault operator as a subchart, the same relationshipservice-gatewayhas withvoyager-gateway.Install wiring
charts/ace-installer/values.yaml— newhelm.releases.service-vaultentry (enabled: false,v2026.9.11). That flag is the only switch; there is no separatesecretManagementblock.charts/ace-installer/templates/featuresets/opscenter-secret-management/service-vault.yaml(new) —HelmReleaseinto theacenamespace, labelledpart-of: opscenter-secret-management,dependsOnopscenter-features/cert-manager/gateway-api. It injectsglobal.registryFQDN,global.imagePullSecrets,clusterMetadata.name: ace, andinfra.host/infra.hostTyperead offhelm.releases.ace.values.global.platform(only when a host is set, so the chart default is not blanked). Same defaults-then-mergeOverwriteshape as the sibling feature templates.resourcetemplates/helmreleases/ace/ace.yaml— theacerelease gains adependsOn: service-vaultentry when the release is enabled.charts/service-vault/Chart.yaml— depends onkubevaultv2026.8.7fromoci://ghcr.io/appscode-charts; newChart.lock, andcharts/service-vault/chartsis gitignored like the other umbrella charts.charts/service-vault/values.yaml— adds aglobalblock (license,licenseSecretName,registry,registryFQDN,imagePullSecrets,distro) that the kubevault subchart inherits.templates/_helpers.tpl—distro.openshift/operator.ubinow read.Values.global.distrowith a.Values.distrofallback, copied fromcharts/service-gateway/templates/_helpers.tpl. Helm helper names are chart-tree-global, so without this the parent definitions shadowed kubevault's and itstests/test-connection.yamlfailed withnil pointer evaluating interface {}.openshift. Newservice-vault.clusterName/gatewayHost/pkiDomainhelpers replace the inlineprintfingw.yamlandissuer.yaml.VaultServer
values.yaml—vaultServergrows from{name}into a full spec:version,replicas,isolateTenants,serviceType,terminationPolicy,persistence,unsealer,tls.caSecretName,relay.{clusterSet,namespace,bootstrapTokenTTL}.apis/installer/v1alpha1/service_vault_types.go—ServiceVaultSpec.VaultServerchanges fromLocalObjectReferenceto a newVaultServerSpec; addsClusterMetadataandGlobal.templates/vault/ca-issuer.yaml(new) — namespaced cert-managerIssuer{{ service-vault.fullname }}-ca-issuerfor the VaultServer's serving TLS. Usesca.secretNamewhenvaultServer.tls.caSecretNameis set, otherwiseselfSigned: {}. Named distinctly from the existingvault-issuerClusterIssuer, which serves the opposite flow (cert-manager issuing certs from Vault's PKI).templates/vault/vault-server.yaml— rewritten around the new values.serviceTemplatesis emitted only whenserviceTypeis notClusterIP, so the Gateway/HTTPRoute exposure ingw.yamlstays the default. Themonitorblock is preserved.hack/scripts/import-crds.sh— bumpsKUBEVAULT_APIMACHINERY_TAGfromv0.23.0tov0.25.0.v0.23.0had noisolateTenants,relayPlacementRef, orrelayTemplateonVaultServer, so structural-schema pruning would have dropped all three at the API server; all four fields the templates emit are present underv1alpha2in the re-imported CRD. Gateway API and caprovider CRDs are no longer vendored into this chart — their own releases install them first.Removed from the
acechartcharts/ace/Chart.yaml(dependency +Chart.lock),charts/ace/values.yaml, andAceSpec.ServiceVaultinapis/installer/v1alpha1/ace_ace_types.go.Verification
make refreshrun; deepcopy, values schemas, chart docs, certified charts, andcatalog/imagelist.yamlare currentgo build ./...cleanhelm templatechecked forcharts/ace,charts/ace-installer(withhelm.releases.service-vault.enabled=true, confirming the new release and theacedependsOnentry), andcharts/service-vault(rendering the chart pluskubevault,kubevault-catalog,kubevault-operator,kubevault-webhook-server,ace-user-roles)sigilr-2.6.1.1, the defaultvaultServer.version, is present in the bundledkubevault-catalog