Repository navigation
Deprecate FormatPostgreSQLType as an alias of spantype.FormatTypePostgreSQL - #8
Merged
Merged
Conversation
…greSQL The spelling table moved to spantype v0.3.12 so type rendering is available at the layer every consumer already depends on (spannersh renders PG headers through it today; spanvalue/spancodec cannot depend on spanpg). The alias delegates and will be removed at the next breaking release. The existing unit table now verifies alias == spantype implementation, and the integration probes keep pinning the spellings against PG-dialect Spanner end to end. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates FormatPostgreSQLType and delegates its implementation to spantype.FormatTypePostgreSQL following an upgrade of the spantype dependency to v0.3.12. Feedback highlights that removing the nil guard in FormatPostgreSQLType could cause panics or change behavior for existing callers, so it is recommended to retain the nil check to preserve backward compatibility.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Open
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to apstndb/spantype#10 (spantype v0.3.12): the PostgreSQL spelling table now lives in spantype, where every type-rendering consumer already sits;
FormatPostgreSQLTypebecomes aDeprecated:alias delegating there, removed at spanpg's next breaking release.Verification discipline preserved: the unit table now pins alias ≡ spantype implementation, and
mise run test-integration(PG-dialect emulator) passes unchanged — the literal round-trip harness exercises the spellings through the alias end to end, so the probe coverage spanpg promised for the table continues here.🤖 Generated with Claude Code