fix: preserve row sequence source errors matching Done - #281
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep yielded iterator.Done, wrapped Done, and joined source failures as errors in RunRowSeq and its deferred-metadata path. Previously they could be mistaken for successful exhaustion and trigger Finish.
Use a private exhaustion sentinel only for an exhausted sequence or native iterator completion. Preserve source error identity, abort without Finish, and release the source once. Document why exact sentinel comparison is intentional.
Validated: direct/wrapped/joined error regressions before and after a successful row, existing lifecycle/deferred-metadata tests, make check, race tests, Example tests, and dbsqlrows/gospanner tests with Go 1.25.13.
Fixes #275.