fix: accept empty DDL affected_rows result sets - #291
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #290.
go-sql-spanner represents a successful DDL statement without query rows as an empty metadata row type followed by a data result set with one synthetic
affected_rowscolumn and immediate EOF. Since #284,RunRowsAtDatarejects that shape before the sink runs, so spannersh aborts atCREATE TABLEwhen using v0.9.1-alpha.1.Accept only that exact placeholder shape after confirming the data result has no row or read error. An actual row, a different column, or any other metadata/column mismatch still returns
ErrMetadataColumnCount; the result retains metadata and no sink callback runs on failure. On the empty case, prepare and finish still run, and the cursor remains available for a following stats result set.Validation: Go 1.25.13
make check; targeted mismatch/EOF/error tests and a Docker-freedatabase/sql/driverregression test covering the publicRunRowsAtDatapath and subsequentNextResultSet. The two spannersh Emulator integration tests reported in #290 also passed with Go 1.26.8 in an isolated copy of spannersha48385b, using a temporary module replacement to this PR head. The downstream checkout was not modified.