Skip to content

Implementing AnyAsync #181

Closed
Closed

Description

@gabrielheming

Following a bit the issue #175. Can the method Task<bool> AnyAsync be implemented?

public interface IReadRepositoryBase<T> where T : class
{
    Task<bool> AnyAsync(ISpecification<T> specification, CancellationToken cancellationToken = default);
    Task<bool> AnyAsync(CancellationToken cancellationToken = default);
}

I think it is a "non-harmful" implementation and it does not seem to break any previous implementation.

Activity

  1. fiseni commented on Dec 9, 2021

    @fiseni
    Collaborator

    Yes, we'll implement this. Check issue #180 too.

  2. gabrielheming commented on Dec 9, 2021

    @gabrielheming
    ContributorAuthor

    I think I let open the issues page yesterday and I haven't seen that.
    BTW, I will make the PR to it if the @devbased doesn't want to.

  3. fiseni commented on Dec 9, 2021

    @fiseni
    Collaborator

    Yeah, please go ahead. Ensure that you're adding the implementation for all plugin packages (EFCore and EF6).
    I can't remember well, but I think EF6 had issues with AnyAsync (the way it is translated). Please let's ensure it works everywhere.

  4. devbased commented on Dec 9, 2021

    @devbased
    Contributor

    @gabrielheming you're welcome and thanks for contribution

  5. added this to the 6.0 milestone on Dec 9, 2021
  6. andrewwilkin commented on Jan 5, 2022

    @andrewwilkin

    Any chance the NuGet Package could be updated please :)

  7. ardalis commented on Jan 5, 2022

    @ardalis
    Owner

    v6 will ship this month (hopefully earlier rather than later). Still catching up since the holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions