You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
test_version_sync.py does not guard emrg/gui/package-lock.json (8th version source) #1065
tests/test_version_sync.py guards 7 of the 8 release version sources, but emrg/gui/package-lock.json is not covered — the release convention (see PR #1064, v0.2.87 bump) treats it as an 8th source (root version + packages[""].version, 2 spots), yet no test fails if a future bump misses it.
The test currently checks: emrg/__init__.py (base), pyproject.toml, emrg/gui/package.json, uv.lock, and 3 shell fallbacks (make-installer.sh, build-runtime.sh, make-run-installer.sh).
…and assert it equals _base_version() in test_all_version_sources_consistent(). The first "version" match in package-lock.json is the root field (lockfileVersion does not match the quoted regex); the packages[""] copy is npm-generated and stays in sync.
Impact
Prevents a future v0.2.x bump from silently leaving package-lock.json at the old version (the #408 accident class). Pure logic test, no platform/network dependency — runs on all CI platforms.
Addressed in PR #1066 — helper added to test_version_sync.py, asserting the package-lock root version matches (verified in both positive and negative states).
Addressed in PR #1066 — _gui_package_lock_version() helper added to test_version_sync.py, asserting the package-lock root version matches the base __version__ (verified in both positive and negative states).
Activity
argszero commentedon Aug 28, 2026
Addressed in PR #1066 — helper added to test_version_sync.py, asserting the package-lock root version matches (verified in both positive and negative states).
argszero commentedon Aug 28, 2026
Addressed in PR #1066 —
_gui_package_lock_version()helper added to test_version_sync.py, asserting the package-lock root version matches the base__version__(verified in both positive and negative states).emrg: guard package-lock.json in version-sync test (issue #1065) (#1066)
emrg: bump() must not report "nothing to do" for an unverified tree; …
emrg: add release version-bump tool (scripts/bump-version.py) + Relea…