fix: surface warning when config thresholds are invalid

[github-actions]

🤖 This is an automated pull request from Repo Assist.

What: Wires ConfigurationManager.validateConfiguration() into extension.ts so that misconfigured thresholds (warningThreshold >= errorThreshold) actually surface a vscode.window.showWarningMessage to the user, both on activation and whenever settings change.

Why: validateConfiguration() already existed and was covered by unit tests (src/test/configuration.test.ts), but nothing in production code ever called it. A user who misconfigures their thresholds would silently get incorrect complexity color-coding with no indication anything is wrong.

Trade-offs: None significant — this is additive and only fires when the configuration is actually invalid. No new dependencies, no behavior change for valid configurations.

Test Status

• npm run compile: ✅ clean
• npm run lint: ✅ clean
• npm run test:unit (c8 + mocha, 225 tests): ✅ all passing, no coverage regression
• vscode-test (extension.ts/configuration.ts activation tests): not run — blocked by sandbox network (VS Code test binary download), as is standard in this environment

Closes: none (proactive improvement; Task 4 substituted with Task 5 this run — all outstanding dependency bumps are already covered by open PRs #546/#501/#455, no new engineering work identified).

Warning

Firewall blocked 1 domain

The following domain was blocked by the firewall during workflow execution:

• releaseassets.githubusercontent.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "releaseassets.githubusercontent.com"

See Network Configuration for more information.

Generated by 🌈 Repo Assist, see workflow run. Learn more.
_{Comment /repo-assist to run again}

_{Add this agentic workflow to your repo}

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@42c2ab5b4e4c9273534c39259b2e0df7f20f07e9

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.89%. Comparing base (4a05683) to head (134ac02).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          10       10           
  Lines        3710     3710           
  Branches      455      455           
=======================================
  Hits         3632     3632           
  Misses         77       77           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[askpt]

@copilot add appropriate unit tests

[Copilot]

@copilot add appropriate unit tests

Added unit tests in src/test/extension.test.ts covering checkConfigurationValidity (commit test: add unit tests for checkConfigurationValidity):

• Valid thresholds → no warning shown
• Equal thresholds (warningThreshold == errorThreshold) → warning shown with "Code Metrics" prefix
• Inverted thresholds (warningThreshold > errorThreshold) → warning shown with both threshold values in the message

checkConfigurationValidity was also exported from extension.ts to enable direct invocation in tests. The tests stub vscode.window.showWarningMessage to capture calls without producing actual UI, following the same config-update pattern used in the existing configuration.test.ts suite.

[askpt]

@copilot the tests are failing at the moment. Fix them

[Copilot]

@copilot the tests are failing at the moment. Fix them

Fixed. The tests were failing because activate() registers an onConfigurationChanged listener that also calls checkConfigurationValidity(), so each vsConfig.update(...) in the test body triggered an extra warning capture before the explicit call — causing counts of 2 and 3 instead of 1.

The fix resets warningMessages = [] after the config updates and before the explicit checkConfigurationValidity() call, so the assertion only counts the one intentionally-tested invocation. See commit fix: clear warningMessages before explicit call to avoid onConfigurationChanged pollution in tests.

[Copilot]

Pull request overview

Surfaces warnings when complexity thresholds are invalid.

Changes:

• Validates configuration during activation and settings changes.
• Adds warning-message integration tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/extension.ts	Adds validation warning wiring.
src/test/extension.test.ts	Tests warning-message behavior.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.