Repository navigation
build(deps): bump surefire.version from 3.0.0-M6 to 3.0.0-M7 - #23
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps `surefire.version` from 3.0.0-M6 to 3.0.0-M7. Updates `maven-surefire-plugin` from 3.0.0-M6 to 3.0.0-M7 - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0-M6...surefire-3.0.0-M7) Updates `maven-failsafe-plugin` from 3.0.0-M6 to 3.0.0-M7 - [Release notes](https://github.com/apache/maven-surefire/releases) - [Commits](apache/maven-surefire@surefire-3.0.0-M6...surefire-3.0.0-M7) --- updated-dependencies: - dependency-name: org.apache.maven.plugins:maven-surefire-plugin dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.apache.maven.plugins:maven-failsafe-plugin dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
the
dependencies
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
astubbs
added a commit
that referenced
this pull request
Sep 2, 2026
…rupt as a wake-up, and end recovery on the failures retrying cannot fix Recovery lifecycle findings #3, #4, #8, #13, #17, #22, #23 and #27 of the #410 review, each with a test that was red against the previous code (run as a mutant of this commit - the old behaviour reinstated line by line - and green after). What changed for a user of the PC-built transactional path: - A replacement producer that was built but failed initTransactions is now closed before the retry is scheduled. It was leaked: nothing held a reference to it, and each one kept a KafkaProducer network thread - about 120 per hour at the 30 s backoff cap while a coordinator was unreachable. Both catch branches close it (ProducerManagerRecoveryTest: aReplacementThatFailsToInitialiseIsClosedBeforeTheRetryIsScheduled, aReplacementThatFailsTerminallyIsClosedToo). - The recovery counter and its log line moved out of the build try. The counter is the user's MeterRegistry, which has thrown from inside PC before (docs/solutions/runtime-errors/a-throwing-meter-registry-kills-the- poll-thread-and-strands-close.md); a throw there turned a published, in-use replacement into a DEFERRED outcome that scheduled a second rebuild against it (aThrowingMeterRegistryDoesNotTurnACompleted ReplacementIntoADeferredOne). - An interrupt while recovery waits for the producer write lock no longer closes the instance. notifySomethingToDo interrupts the control thread whenever the write lock is not HELD, and it is not held while WAITING for it - which recovery does for as long as a worker holds the produce lock through its user function; the rebalance that fenced the producer ends with onPartitionsAssigned, which notifies. The InterruptedException escaped maybeRecoverProducer's RuntimeException catch and the supervisor closed PC with no failure cause. It is now caught, cleared and the pass returns; the condition stays recorded and the next pass retries, the same shape as the mailbox poll's own catch. maybeRecoverProducer no longer declares InterruptedException, so the compiler holds the line (ProducerRecoveryTest: aWakeUpInterruptWhileRecoveryWaitsForTheWriteLock DoesNotCloseTheInstance - one record only, so the commit path's separate, pre-existing exposure to the same interrupt does not take it first). - An Error from the user's ProducerFactory is terminal. The factory is user code and is now wrapped by UserFunctions.carefullyRun like every other user function; an Error in the cause chain (a serializer's static initialiser failing, say) is deterministic and joins AuthorizationException and UnsupportedVersionException as a terminal build failure, so the instance closes naming the type, and its parked workers are released by the close. Before, the Error escaped every catch on the recovery path: the supervisor's catch is Exception, so the instance stayed RUNNING with every worker parked on the produce lock for good. maybeRecoverProducer also catches Error from anywhere else in the pass, records it as the failure reason and transitions to CLOSING before rethrowing, for the same release (anErrorFromTheFactoryIsTerminalAndClosesTheInstanceNamingIt). - A factory contract violation is terminal, not deferred. Returning null, returning the producer it already returned, or building a producer that does not carry the transactional.id PC handed it now raise ProducerFactoryContractException, a dedicated type the terminal predicate recognises. Every one is deterministic - a caching factory caches on every rebuild, never only the first - so retrying was a WARN-per-attempt loop for the life of the instance (aFactoryContractViolationIsTerminalRather ThanRetriedForever). - Recovery is skipped once the instance is CLOSING or CLOSED. A close during an outage otherwise waited on a rebuild that blocks up to max.block.ms for a producer nobody would use; ProducerManager.close releases the parked workers on its own. DRAINING still recovers, because a drain needs a producer to finish the work in flight (noReplacementIsAttemptedOnceThe InstanceIsClosing, driven directly - the window is the control thread's). Smaller: the two raw producerWrapper call sites the field javadoc claimed did not exist (sendOffsetsToTransaction and beginTransaction) go through producer(), and the javadoc now says exactly which paths read the field raw (the constructor and initProducer, before any replacement can exist); restoreWorkDiscardedByAbortedTransaction's count is named at its call site per the house rule; the pollAndProduceMany guard names producerConfig first and the Producer instance as deprecated. The terminal failure names the root cause's type as well as the wrapper's - types only, never messages, which may carry configuration values (R7). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VrpH51xNDodaajE4P2nhFg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
surefire.versionfrom 3.0.0-M6 to 3.0.0-M7.Updates
maven-surefire-pluginfrom 3.0.0-M6 to 3.0.0-M7Release notes
Sourced from maven-surefire-plugin's releases.
Commits
fcdd766[maven-release-plugin] prepare release surefire-3.0.0-M7559db4c[SUREFIRE-2086] Management of temporary files (#535)bce6b43[SUREFIRE-2067] Improve site configurationec47652move this version changelog to a dedicated page (#539)535855a[SUREFIRE-2077] Allow consecutive spaces in argLine (#527)2cf4674[SUREFIRE-2075] Only set thread count if spec'd7008175Bump javacc from 7.0.10 to 7.0.11 (#524)03cafcaBump javassist from 3.22.0-GA to 3.29.0-GA8fa3098[SUREFIRE-2083] Remove redundant config from maven-shade-plugin17628ad[SUREFIRE-2081] Upgrade Parent to 36Updates
maven-failsafe-pluginfrom 3.0.0-M6 to 3.0.0-M7Release notes
Sourced from maven-failsafe-plugin's releases.
Commits
fcdd766[maven-release-plugin] prepare release surefire-3.0.0-M7559db4c[SUREFIRE-2086] Management of temporary files (#535)bce6b43[SUREFIRE-2067] Improve site configurationec47652move this version changelog to a dedicated page (#539)535855a[SUREFIRE-2077] Allow consecutive spaces in argLine (#527)2cf4674[SUREFIRE-2075] Only set thread count if spec'd7008175Bump javacc from 7.0.10 to 7.0.11 (#524)03cafcaBump javassist from 3.22.0-GA to 3.29.0-GA8fa3098[SUREFIRE-2083] Remove redundant config from maven-shade-plugin17628ad[SUREFIRE-2081] Upgrade Parent to 36Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)