This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Add support for JSX tags to the CoffeeScript grammar - #172
Merged
Merged
Conversation
In CoffeeScript 2.0, JSX tags became part of the language (https://coffeescript.org/#jsx). This change adds recognition of tags and attributes to the existing coffeescript grammar.
And, also kick the build which seems to have hiccupped
1 task done
|
Thanks! Someone from the team will take a look as soon as they can. |
Contributor
|
Thanks for the contribution! We're currently deciding the way forward for our official language packages with the advent of tree-sitter. We'll get back to you as soon as we can once we make some other decisions. |
Author
|
@lee-dohm Ok, thanks. Let me know either way. I could possibly contribute to a tree-sitter solution if you go that direction. |
smashwilson
approved these changes
Jan 25, 2019
smashwilson
left a comment
smashwilson
left a comment
Contributor
There was a problem hiding this comment.
👍 Gave it a shot with some of the CoffeeScript JSX examples and it looks good to me. 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
In CoffeeScript 2.0, JSX tags became part of the language (https://coffeescript.org/#jsx). This change adds recognition of tags and attributes to the existing CoffeeScript grammar.
Alternate Designs
No other designs were considered as this is a simple addition to an exisiting grammar.
Benefits
This change will add syntax highlighting for JSX tags and attributes in Atom.
Possible Drawbacks
A bug could cause incorrect tokenization of CoffeeScript code and cause issues in syntax highlighting
Applicable Issues
#135