This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Repository navigation
Don't show notifications for stacks without absolute file paths - #62
Merged
Merged
Conversation
kevinsawicki
added a commit
that referenced
this pull request
May 18, 2015
Don't show notifications for stacks without absolute file paths
This was referenced May 18, 2015
This was referenced Jun 10, 2015
This was referenced Jul 6, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are cases where a stack traces only contains file paths for node built-ins such as process and fs and are impossible to trace to a specific package or core file, so don't show notifications for them.
This can be as simple as calling
fs.readFile('/')without a callback which currently causes a notification with a stack trace of:This pull request scans each stack and only shows notifications for ones that contain at least one absolute path meaning it comes from a known package or core source file.
The errors still go to Console tab in the dev tools.
Closes atom/atom#4708
Closes atom/atom#4710
Closes atom/atom#4735
Closes atom/atom#4805
Closes atom/atom#5315
Closes atom/atom#5634
Closes atom/atom#5956
Closes atom/atom#6095
Closes atom/atom#6184
Closes atom/atom#6191
Closes atom/atom#6213
Closes atom/atom#6256
Closes atom/atom#6326
Closes atom/atom#6339
Closes atom/atom#6468
Closes atom/atom#6804
/cc @izuzak I tried to link all the relevant uncaught issues I could find
/cc @benogle