Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

"Featured Packages" is showing featured themes as well #1090

Open

Description

@Arcanemagus

Prerequisites

Description

The list of Featured Themes is being added to the list of Featured Packages.

Steps to Reproduce

  1. Open Atom in Safe Mode
  2. Go to Settings -> Install
  3. Look at the list of Featured Packages

Expected behavior:

Only packages show in the Featured Packages.

Actual behavior:

Themes are showing in the package list:
image

Reproduces how often:

100% of the time.

Versions

OS: Windows 10 x64

Atom    : 1.34.0-nightly8
Electron: 2.0.12
Chrome  : 61.0.3163.100
Node    : 8.9.3
apm  2.1.3
npm  6.2.0
node 8.9.3 x64
atom 1.34.0-nightly8
python 2.7.15
git 2.19.1.windows.1
visual studio 2015

Additional Information

Looks like this is the inverse of #304.

Activity

  1. winstliu commented on Nov 3, 2018

    @winstliu
    Contributor

    👍 from me on adding a --packages argument to apm and simply propagating that flag in settings-view rather than trying to filter out themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions