Repository navigation
fix: layered template waits for the seeked video frame, not a stale pre-seek one (#10465) - #10475
Merged
Merged
Conversation
… a presented take (#10465) The seek's presented-frame callback also fires for the clip's time-0 frame painted after load, so an excerpt could capture the first frame before the seek landed. A callback now counts only when its mediaTime is within a frame of the seek target; otherwise it re-arms. No added sleeps.
atomantic
force-pushed
the
claim/issue-10465
branch
from
October 7, 2026 10:05
63f2009 to
dc15ca0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10465
The layered engine's presented-frame callback also fires for the clip's time-0 frame painted after load, so an excerpt could capture the first frame (pure red) before the seek landed. A callback now counts only when its
mediaTimeis within one frame of the seek target; otherwise it re-arms. No added sleeps; the existing grace fallback is unchanged.Test plan:
documentRender.browser.test.js8/8 locally; pregate green. The CI flake is load-dependent, so confirmation is repeated DB-test runs.