fix(ci): enforce glibc 2.28 floor for Linux releases - #185
Open
vinceblock99 wants to merge 2 commits into
Open
Conversation
Build both Linux GNU artifacts with cargo-zigbuild against glibc 2.28 and reject artifacts that exceed the supported symbol floor. Pin the Zig setup action and keep build jobs read-only.
# Conflicts: # .github/workflows/release.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo-zigbuildagainst an explicit glibc 2.28 floor.This preserves the current GNU artifact names and fixes their compatibility directly. PR #183 takes the alternative approach of adding separate musl artifacts while leaving the GNU artifacts unchanged.
Root cause
The v0.17.1 GNU binaries were built directly on
ubuntu-latest, so they inherited GLIBC 2.38/2.39 symbols from the hosted runner and failed to start on Ubuntu 22.04 (glibc 2.35).Test coverage
No application code paths changed. The release workflow now validates both Linux GNU artifacts against the declared GLIBC floor.
Verification
cargo test --workspaceactionlintx86_64-unknown-linux-gnu.2.28andaarch64-unknown-linux-gnu.2.28with cargo-zigbuild 0.23.4 / Zig 0.16.0GLIBC_2.28GLIBC_2.39) and accepts the rebuilt artifact (GLIBC_2.28)Review notes
The remaining non-blocking follow-up is to run baseline-distro smoke tests in PR CI so future loader, shared-library, or CPU-baseline regressions are caught before a release.
Fixes #181