Skip to content

Add support for provisioning_ticket_url property to Connection POJO #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lbalmaceda merged 2 commits into from
Aug 7, 2017
Merged

Add support for provisioning_ticket_url property to Connection POJO #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f6ab01
Update the POJO to support provisioning_ticket_url for AD/LDAP connec…
jbasiglio Jul 26, 2017
4fc83f5
Add test for ad ticket url support
Aug 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/main/java/com/auth0/json/mgmt/Connection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ public class Connection {
private String strategy;
@JsonProperty("enabled_clients")
private List<String> enabledClients = null;
@JsonProperty("provisioning_ticket_url")
private String provisioningTicketUrl;

public Connection() {
}
Expand Down Expand Up @@ -105,5 +107,15 @@ public List<String> getEnabledClients() {
public void setEnabledClients(List<String> enabledClients) {
this.enabledClients = enabledClients;
}

/**
* Getter for the ad/ldap connection's ticket url.
*
* @return the provisioning ticket url.
*/
@JsonProperty("provisioning_ticket_url")
public String getProvisioningTicketUrl() {
return provisioningTicketUrl;
}

}
}
16 changes: 16 additions & 0 deletions src/test/java/com/auth0/json/mgmt/ConnectionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ public class ConnectionTest extends JsonTest<Connection> {
private static final String json = "{\"name\":\"my-connection\",\"strategy\":\"auth0\",\"options\":{},\"enabled_clients\":[\"client1\",\"client2\"]}";
private static final String readOnlyJson = "{\"id\":\"connectionId\"}";

private static final String jsonAd = "{\"name\":\"my-ad-connection\",\"strategy\":\"ad\",\"provisioning_ticket_url\":\"https://demo.auth0.com/p/ad/ddQTRlVt\",\"options\":{},\"enabled_clients\":[\"client1\",\"client2\"]}";

@Test
public void shouldSerialize() throws Exception {
Connection connection = new Connection("my-connection", "auth0");
Expand All @@ -27,6 +29,7 @@ public void shouldSerialize() throws Exception {
assertThat(serialized, JsonMatcher.hasEntry("strategy", "auth0"));
assertThat(serialized, JsonMatcher.hasEntry("options", notNullValue()));
assertThat(serialized, JsonMatcher.hasEntry("enabled_clients", Arrays.asList("client1", "client2")));
assertThat(serialized, JsonMatcher.hasEntry("provisioning_ticket_url", null));
}

@Test
Expand All @@ -38,6 +41,19 @@ public void shouldDeserialize() throws Exception {
assertThat(connection.getOptions(), is(notNullValue()));
assertThat(connection.getStrategy(), is("auth0"));
assertThat(connection.getEnabledClients(), contains("client1", "client2"));
assertThat(connection.getProvisioningTicketUrl(), is(nullValue()));
}

@Test
public void shouldDeserializeAd() throws Exception {
Connection connection = fromJSON(jsonAd, Connection.class);

assertThat(connection, is(notNullValue()));
assertThat(connection.getName(), is("my-ad-connection"));
assertThat(connection.getOptions(), is(notNullValue()));
assertThat(connection.getStrategy(), is("ad"));
assertThat(connection.getEnabledClients(), contains("client1", "client2"));
assertThat(connection.getProvisioningTicketUrl(), is("https://demo.auth0.com/p/ad/ddQTRlVt"));
}

@Test
Expand Down