Conversation
… persist to /shared
test-aiperf.sh ran aiperf profile with no --artifact-dir, so results lived only in the
ephemeral do-aiperf pod and were lost on pod delete. Adding --artifact-dir by hand is
error-prone: a missing space between the artifact-dir value and the next flag makes aiperf
glue them and reject the URL as an unattached positional ('Unused Tokens: [http://...:8000]',
exit 1) even though serving is healthy.
Add --artifact-dir ${ARTIFACT_DIR} to the built command (space-delimited, before --url) and
default ARTIFACT_DIR=${MODEL_PATH}/aiperf in the test .env. The do-aiperf pod already mounts
fsx-pvc at /shared, so results now persist on the shared filesystem across pod restarts
(also sidesteps the empty-CSV-on-pod-delete gotcha). .env-overridable.
Verified: envsubst render shows '--artifact-dir "..." --url "..."' with correct spacing;
bash -n clean.
Signed-off-by: Anton Alexander <dmvevents@gmail.com>
Contributor
|
suggested change is already in place, closing PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test-aiperf.shrunsaiperf profilewith no--artifact-dir, so results live only in the ephemeraldo-aiperfpod and vanish when the script deletes it at the end. Adding the flag by hand is a footgun: a missing space between the artifact-dir value and the next flag makes aiperf glue them and reject the URL as an unattached positional —— even though the server is healthy (chat/completions work).
Fix
--artifact-dir "${ARTIFACT_DIR}"to the built command, space-delimited, before--url.ARTIFACT_DIR=${MODEL_PATH}/aiperfin the test.env(.env-overridable).do-aiperfpod already mountsfsx-pvcat/shared, so results now persist on the shared filesystem across pod restarts (also sidesteps the empty-CSV-on-pod-delete gotcha).Verification
envsubstrender shows--artifact-dir "/shared/.../aiperf" --url "http://...:8000"with correct spacing.bash -nclean.