Repository navigation
fix: make cdk/destroy.sh executable - #81
Open
bcfmtolgahan wants to merge 1 commit into
Open
bcfmtolgahan wants to merge 1 commit into
bcfmtolgahan wants to merge 1 commit into
Conversation
Both destroy.sh files are committed 100644 while deploy.sh next to them
is 100755. The READMEs tell you to run them directly:
scaled-execution-containers/README.md:391 ./destroy.sh
scaled-execution-containers/cdk/README.md:292 ./destroy.sh
scaled-execution-containers/cdk/README.md:431 ./destroy.sh
agentic-atx-platform/cdk/README.md:69 ./destroy.sh
which fails with permission denied on a fresh clone.
The container scripts are also 100644 but Dockerfile:140 does
chmod +x /app/*.sh at build time, so those are fine. destroy.sh has no
equivalent step - it is meant to be run by hand.
Mode change only, no content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description
cdk/destroy.shis committed as100644in bothscaled-execution-containersandagentic-atx-platform, whiledeploy.shsitting next to it is100755:Four places in the docs tell you to run it directly, so on a fresh clone you get
permission denied:Worth noting so it does not look like an oversight on my side:
container/entrypoint.sh,download-source.shandupload-results.share also100644, butcontainer/Dockerfile:140runschmod +x /app/*.shat image build, so those are fine as they are.destroy.shhas no equivalent step anywhere - it is meant to be run by hand.Mode change only, no content changes.
Testing
git ls-files -sbefore and after;bash -non both files still passes.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.