Skip to content

setup.sh: bootstrap into CDKToolkit-atxinfra instead of overwriting the shared CDKToolkit #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chenxqdu wants to merge 1 commit into
base: atx-remote-infra
Choose a base branch
from
Open

setup.sh: bootstrap into CDKToolkit-atxinfra instead of overwriting the shared CDKToolkit #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 45 additions & 3 deletions setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,12 +157,54 @@ CDK="npx cdk"
info "CDK CLI $($CDK --version 2>&1 | head -1)"

# --- Bootstrap CDK (idempotent) ---
# Keep our bootstrap in its own toolkit stack: `cdk bootstrap --qualifier atxinfra`
# without --toolkit-stack-name writes into the default stack name CDKToolkit, which
# replaces the shared hnb659fds bootstrap every other CDK app in the account uses
# (its roles and SSM parameter get deleted; bucket and ECR repo are left orphaned).
# teardown.sh already looks for CDKToolkit-atxinfra first, so this is the intended layout.

echo "Bootstrapping CDK (if needed)..."
if ! $CDK bootstrap "aws://${ACCOUNT_ID}/${REGION}" --qualifier atxinfra; then
fail "CDK bootstrap failed. Check the error above."
ATX_TOOLKIT_STACK="CDKToolkit-atxinfra"
BOOTSTRAP_VERSION=$(aws ssm get-parameter --name /cdk-bootstrap/atxinfra/version \
--region "$REGION" --query 'Parameter.Value' --output text 2>/dev/null || echo "")
case "$BOOTSTRAP_VERSION" in ''|*[!0-9]*) BOOTSTRAP_VERSION="" ;; esac

if [ -n "$BOOTSTRAP_VERSION" ]; then
# Already bootstrapped for our qualifier. Find the stack that owns those resources so
# we never create a second stack over the same physical resource names (roles, SSM
# parameter and ECR repo would fail with AlreadyExists; the bucket would end up
# managed by two stacks).
OWNING_STACK=""
for CANDIDATE in "$ATX_TOOLKIT_STACK" CDKToolkit; do
CANDIDATE_QUALIFIER=$(aws cloudformation describe-stacks --stack-name "$CANDIDATE" --region "$REGION" \
--query "Stacks[0].Parameters[?ParameterKey=='Qualifier'].ParameterValue" --output text 2>/dev/null || echo "")
if [ "$CANDIDATE_QUALIFIER" = "atxinfra" ]; then
OWNING_STACK="$CANDIDATE"
break
fi
done

if [ -z "$OWNING_STACK" ]; then
warn "/cdk-bootstrap/atxinfra/version exists (v$BOOTSTRAP_VERSION) but no stack owns it — leftover bootstrap resources may need manual cleanup"
if ! $CDK bootstrap "aws://${ACCOUNT_ID}/${REGION}" --qualifier atxinfra --toolkit-stack-name "$ATX_TOOLKIT_STACK"; then
fail "CDK bootstrap failed. Check the error above."
fi
info "CDK bootstrapped ($ATX_TOOLKIT_STACK)"
elif [ "$BOOTSTRAP_VERSION" -ge 21 ]; then
info "CDK already bootstrapped for qualifier atxinfra (v$BOOTSTRAP_VERSION in stack $OWNING_STACK) — skipping"
else
warn "atxinfra bootstrap is v$BOOTSTRAP_VERSION — upgrading stack $OWNING_STACK in place"
if ! $CDK bootstrap "aws://${ACCOUNT_ID}/${REGION}" --qualifier atxinfra --toolkit-stack-name "$OWNING_STACK"; then
fail "CDK bootstrap failed. Check the error above."
fi
info "CDK bootstrapped ($OWNING_STACK)"
fi
else
if ! $CDK bootstrap "aws://${ACCOUNT_ID}/${REGION}" --qualifier atxinfra --toolkit-stack-name "$ATX_TOOLKIT_STACK"; then
fail "CDK bootstrap failed. Check the error above."
fi
info "CDK bootstrapped ($ATX_TOOLKIT_STACK)"
fi
info "CDK bootstrapped"

# --- Deploy ---

Expand Down