Repository navigation
shopping-concierge and kb-search: cap mcp below 2 so the images start - #133
Merged
Merged
Conversation
vishalhabib99
requested review from
bikashkbeheraaws and
vivibui
as code owners
November 4, 2026 16:46
Contributor
Author
|
Hi, just checking whether this one is on your radar. New shopping-concierge image builds and the |
vivibui
approved these changes
Nov 7, 2026
Contributor
Author
|
Thanks @vivibui for reviewing and merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The shopping-concierge Dockerfiles run
pip install --no-cache-dir -r requirements.txt, and these requirements files leavemcpwithout an upper bound, so a new image build now gets mcp 2.3.0. mcp 2.x removed what this code imports, so each one fails on import:mcp_cart_tools/server.py,mcp_shopping_tools/serp_agent.pyfrom mcp.server import FastMCPImportErrorsupervisor_agent/gateway_client.pyfrom mcp.client.streamable_http import streamablehttp_clientImportError(renamed tostreamable_http_client)kb-search-mcp/server.pyfrom mcp.server.fastmcp import ...ModuleNotFoundErrorType of Change
Changes Made
<2tomcpin those fourrequirements.txtfiles. Moving to the 2.x API can be a separate change.case-management/agentcore_sars/app/SARAgenthas the same open bound inpyproject.toml, but itsuv.lockpins mcp 1.x, so I left it alone.Testing
uv pip compile, Python 3.12)mcp==2.3.0mcp==1.30.0I also ran these in clean environments, and each works on mcp 1.30.0 and fails on 2.3.0:
from mcp.server import FastMCP(ImportError),from mcp.client.streamable_http import streamablehttp_client(ImportError),from mcp.server.fastmcp import FastMCP(ModuleNotFoundError). I did not run the images end to end.