Xml Shape Serializer - Schema serde #3855
Open
pulimsr wants to merge 19 commits into
Open
Conversation
sbiscigl
reviewed
Jul 8, 2026
sbiscigl
left a comment
sbiscigl
left a comment
Collaborator
There was a problem hiding this comment.
before moving forward with any of the comments, lets try to figure out what the outcome here is that we want
sbiscigl
approved these changes
Jul 8, 2026
| namespace smithy { | ||
| namespace schema { | ||
|
|
||
| static int s_traitIdCounter = 0; |
Collaborator
There was a problem hiding this comment.
this should be std::atomic to match how java does it
| TraitMap() = default; | ||
|
|
||
| template <typename T> | ||
| const T* Get(const TraitKey<T>& key) const { |
Collaborator
There was a problem hiding this comment.
lets return by value and copy or shared pointer if we want to share lifetimes, raw pointer or ref will create lifetime issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that applies:
Check which platforms you have built SDK on to verify the correctness of this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.