Repository navigation
fix(deploy-on-aws): dedupe duplicate iot key in aws4-shapes.json - #280
Open
avneetbansal-aws wants to merge 1 commit into
Open
avneetbansal-aws wants to merge 1 commit into
avneetbansal-aws wants to merge 1 commit into
Conversation
avneetbansal-aws
requested review from
a team,
arnewouters,
krokoko and
laithalsaadoon
October 2, 2026 17:16
The shape registry had two top-level `iot` entries. Lenient parsers keep the last one, so the first block (fillColor #1A9C37) was silently shadowed by a second block that used #3F8624 (the Storage color) and a shorter shape list. This dropped ~45 valid iot_* shape names from the set built by validate_drawio.py and broke the strict check-json pre-commit hook. Merge the two entries into a single `iot` category: keep fillColor #1A9C37 (matching the authoritative IoT mapping in fix_icon_colors.py) and take the union of both shape lists so no valid shape name is lost. Fixes awslabs#216 Signed-off-by: avneetbansal-aws <avneetbansal-aws@users.noreply.github.com>
avneetbansal-aws
force-pushed
the
fix/aws4-shapes-duplicate-iot-key
branch
from
October 8, 2026 15:25
aaac1f9 to
1138cc4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #216.
plugins/deploy-on-aws/scripts/lib/aws4-shapes.jsonhas two top-leveliotentries. A lenient JSON parser keeps the last one, so the first block (fillColor#1A9C37) was being silently shadowed by a second block that used#3F8624, which is the Storage category color, and carried a shorter list of shape names. The strictcheck-jsonpre-commit hook rejects the duplicate key outright, which is how the issue surfaced.The shadowing also had a quieter effect.
validate_drawio.pybuilds its set of valid shapes by walkingcategories, so once the second block won, roughly 45iot_*shape names from the first block (for exampleiot_camera,iot_lightbulb,iot_mqtt,iot_sensor,iot_greengrass) stopped counting as valid.This merges the two entries into a single
iotcategory. It keeps#1A9C37, which is the IoT color used infix_icon_colors.py, and takes the union of both shape lists so no valid name is lost. The three names that were unique to the second block (greengrass,internet_of_things,iot_edukit) are preserved.Verified with
pre-commit run check-json --all-files, which now passes. I also loaded the registry the wayvalidate_drawio.pydoes and confirmed the previously shadowediot_*shapes are present again, 1100 shapes total.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.