Repository navigation
fix: correct executable bits on docs and scripts - #281
Open
avneetbansal-aws wants to merge 2 commits into
Open
avneetbansal-aws wants to merge 2 commits into
avneetbansal-aws wants to merge 2 commits into
Conversation
Two pre-commit hooks failed on wrong Unix executable bits: - check-executables-have-shebangs: 6 hyperpod-* `.md` docs were marked executable (100755) with no shebang. Docs should not be executable; cleared the bit (-> 100644). - check-shebang-scripts-are-executable: 9 `.py` scripts have a `#!/usr/bin/env python3` shebang but were not executable; set the bit (-> 100755). (Issue awslabs#215 listed 2; the set has since grown to 9, all with shebangs flagged by the hook on current main.) Fixes awslabs#215
avneetbansal-aws
requested review from
a team,
arnewouters,
krokoko and
laithalsaadoon
October 2, 2026 17:28
avneetbansal-aws
requested review from
Benjscho,
anwesham-lab,
gxjx-x,
jaichabria,
pkale,
praba2210 and
spencercorwin
October 2, 2026 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #215.
Two pre-commit hooks fail because of wrong Unix executable bits.
check-executables-have-shebangsflags sixhyperpod-*.mddocs that are tracked as executable (100755) with no shebang, andcheck-shebang-scripts-are-executableflags Python scripts that carry a#!/usr/bin/env python3shebang but are not executable. This clears the executable bit on the docs and sets it on the scripts.The issue listed two scripts when it was filed, but the hook now flags nine on current
main, since more scripts were added in the meantime. All nine have shebangs and are flagged, so this fixes the full current set rather than leaving the hook red after a partial fix.Docs that had the executable bit cleared:
Shebang scripts that had the executable bit set:
No file contents changed, only mode bits. Both hooks pass locally after the change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.