Repository navigation
Add support for Vite 5 #103
Description
Thanks for writing this awesome plugin.
Given that deps were not updated yet to support Vite 5, we're seeing a warning: unmet peer vite@^4.0.0: found 5.0.3.
Reacted by Matt Ayres, Miłosz Filimowski, Grzegorz Szeliga, RWaelen, Max, Victor Cardins, José D. Gutiérrez, Jason Walsh, Ian Bytchek, floratmin and 46 more
Activity
vcardins commentedon Dec 13, 2023
Any updates on this?
DavidTsGit commentedon Feb 29, 2024
Hi. I've got this issue too. Any chance of this being resolved? Thanks!
nlwillia commentedon Mar 1, 2024
My impression is that plugins like this might be less relevant (or at least much simplified) once the new runtime API stabilizes. It directly addresses the module-graph/HMR stuff by moving what vite-node was doing into the core.
ZeldOcarina commentedon Aug 22, 2024
Any news on this one?
palfaro91 commentedon Sep 13, 2024
Will Vite v5 be supported?
dirkluijk commentedon Sep 20, 2024
It seems that adding support for Vite 5 is quite easy, I just submitted a pull request: #112
@axe-me Is this project still maintained? Could you have a look?
axe-me commentedon Sep 22, 2024
Hi guys, work's crazy busy for me recently again. I will find some time tmr to look into vite5 support. I know vite 5 has some breaking changes and removed some deprecated features this plugin uses. I will see what I can do to make this plugin supports vite5 and backward compatible at the same time.
ZeldOcarina commentedon Sep 22, 2024
You are amazing!! Actually this plugin is the only way I found to make Node work with Vite so thank you so much!!!
dirkluijk commentedon Sep 22, 2024
@axe-me No worries! Many thanks. The plugin is amazing indeed. Let me know if I can help you with anything.
As far as I could see, I was able to use the plugin with Vite 5 after upgrading its dependencies. So maybe we could even support Vite 4 and 5 simultaneously.
Alternatively, we could release a major version and include a compatibility matrix in the
README.md. :)eugeniosegala commentedon Oct 3, 2024
Would it be possible to review and merge @dirkluijk's PR? 🙏
#112
dirkluijk commentedon Oct 7, 2024
Since I am depending on this plugin for an enterprise project, I am also willing to fork this project and taking a bit of ownership in its development in another open-source fork. Considering this project is MIT licensed, that seems appropriate. @axe-me what's your thought on this?
However, I'd consider droppingswcsupport then, to make the forked project simpler. What is the business case to useswcas compiler instead ofesbuild?Update: never mind, I see it's mainly because of NestJS, which doesn't have proper support for esbuild yet.
dirkluijk commentedon Oct 8, 2024
Eventually, I ended up adopting part of the source code for my own plugin, without the SWC compiler and only supporting Express. The code is actually very straightforward, if anyone is interested, here is a gist:
https://gist.github.com/dirkluijk/e1a57bd09a13ee55695907e81c7123a2
axe-me commentedon Oct 9, 2024
Hi guys, I just released a new version, 4.0.0, which supports vite 5. Most simple test cases are passed. However, there are some commonjs issues when I try to use it in my large project (because the buildSsrCjsExternalHeuristics option is removed in vite5). I will try to figure out a solution for that, but in the meantime please test out the version, and let me know if you find more issues.