Skip to content

Amp and Droid adapters ignore the feedback field on approved annotate decisions #1137

Closed

Description

@backnotprop

The new Approve with Notes flow (#1092) emits decision: "approved" with a feedback field carrying the reviewer's notes. Two adapters ignore it:

  • apps/droid-plugin/lib/run-plannotator.js (emitAnnotateDecision) prints only "Approved." for approved decisions
  • apps/amp-plugin/plannotator.ts (formatAnnotationFeedback) returns null for anything that is not "annotated"

So on Amp and Droid the button appears and the notes are silently dropped, the same data-loss class #1092 fixed elsewhere. Fix is to surface the feedback text when present, with prompt wording chosen per adapter.

Activity

  1. added a commit that references this issue on Jul 28, 2026
    54127df
  2. added a commit that references this issue on Jul 30, 2026
    26681ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions