You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Quick labels: inconsistent across newer features, and a highlight can't be both labelled and commented #2626
The Quick Label feature seems to have drifted, and become messy across the features added since #268. Here's what I found:
The label's tip only reaches the agent from the main feedback export. Three other places
drop it:
Share links. The link carries the label flag but not the tip, so a label from a
shared review exports without its instruction (sharing.ts).
"Ask" about draft annotations. A label becomes one line, label "🔍 Verify this" on "…",
with no tip (formatDraftAnnotationsForAsk in parser.ts).
Inbox message comments. They give a label its [🔍 Verify this] heading but no tip
(packages/inbox/attachments.ts).
The feedback archive's structured record drops the label flag.index.jsonl keeps the
annotations as data, but FeedbackAnnotationRecord has no isQuickLabel or tip field. In the
data, a label is just a comment whose text is 🔍 Verify this. Only the feedback text still shows
it as a label (packages/shared/feedback-archive.ts).
The 👍 has two names. In the ⚡ picker it is "Nice approach". The standalone button on the
toolbar, the HTML pinpoint composer and the image lightbox is "Looks good" (quickLabels.ts).
These came up when I wanted to add a quick-label menu to the comment box, so that a label and a
comment could be used together or separately. If the delete button moved into the comment box
too, it would save extra clicks and streamline the process: select, then comment, label, mark for
deletion, or any mix of them, all in one place.
The problem I ran into with doing that cleanly is that Plannotator is structured to make you choose
between a comment, a label and a deletion. Each one is its own annotation:
A comment holds your text.
A label is a comment whose text is the label, plus a flag and the label's tip. It can't hold
your own words as well.
A deletion is a separate type that exports as "Remove this" and the quoted text, with no
comment.
So putting a label on a comment means either replacing the comment or making two annotations on
the same text.
My question is: is that restriction really needed? A deletion is really a special quick label,
one that also strikes the text out. So a highlight could be any of:
a deletion, with or without a comment;
a quick label, with or without a comment;
a plain comment.
A deletion and a quick label wouldn't go on the same highlight.
For example:
## 1. (line 12) [🔍 Verify this] Feedback on: "retries a failed payout three times"
> This seems like an assumption. Verify by reading the actual code before proceeding.
> Is it really three? The config says five.
## 2. (line 20) Remove this
```
Fall back to the legacy payout queue.
```
> The legacy queue was removed last month.
One label per highlight seems enough to me, but I'm not against allowing more than one, say
🔍 Verify this and 🚫 Out of scope together.
I saw that #1693 kept a 👍 out of the comment box, since it "doesn't exist elsewhere", and that #1712 brought it back only where no toolbar shows. So I'd rather ask before building anything. Is
this a direction you'd take? If it is, I'm happy to work out the model change and the export
format in a PR.
Thank you, Ben, this is a really useful audit. We checked each point and you're right on all of them: the label's tip is lost in share links, in Ask, and in Inbox message comments, the archive record drops the label, and 👍 has two names (three, counting the HTML view). The lost tips and the archive record are fixed in #2811 (merged), and 👍 will be called "Looks good" everywhere. Thanks again for checking so carefully.
Your welcome, but really the only reason I looked into this in the first place was because I was wanting to allow annotation items to be allowed to hold both Labels/Deletes and Comments.
And combine the mark up picker modal and the comment model.
The goal was making the whole UX around those items smooth.
Right now you are forced to choose if a annotations is a Comment or a Label or a delete.
That is what I am looking to understand the reasoning be hind, and wondering if it needs ro be that way.
Activity
Quick labels: keep the label's tip in share links, Ask, Inbox comment…
backnotprop commentedon Nov 7, 2026
Thank you, Ben, this is a really useful audit. We checked each point and you're right on all of them: the label's tip is lost in share links, in Ask, and in Inbox message comments, the archive record drops the label, and 👍 has two names (three, counting the HTML view). The lost tips and the archive record are fixed in #2811 (merged), and 👍 will be called "Looks good" everywhere. Thanks again for checking so carefully.
BenNewman100 commentedon Nov 7, 2026
@backnotprop
Your welcome, but really the only reason I looked into this in the first place was because I was wanting to allow annotation items to be allowed to hold both Labels/Deletes and Comments.
And combine the mark up picker modal and the comment model.
The goal was making the whole UX around those items smooth.
Right now you are forced to choose if a annotations is a Comment or a Label or a delete.
That is what I am looking to understand the reasoning be hind, and wondering if it needs ro be that way.