Skip to content

fix(ui): drop the annotation count pill from the header decision primary - #1516

Merged
backnotprop merged 2 commits into
mainfrom
fix/decision-control-no-count
Sep 12, 2026
Merged

backnotprop merged 2 commits into
mainfrom
fix/decision-control-no-count

Conversation

@backnotprop

Copy link
Copy Markdown
Owner

Summary

  • The header decision primary no longer renders the inline count pill: it reads Send Feedback / Post Comments, not Send Feedback · n (maintainer ruling).
  • DecisionPrimary.count is removed from the pure spec; the annotation count still drives the caret menu's discard and approve-with-notes copy, which is where it is needed.
  • decisionSpec.test.ts and the review App.decisionControl suite now pin that the primary label carries no digits; AGENTS.md and tests/UI-TESTING.md stop spelling the control with a count.

Below the label breakpoint the primary is icon-only, the same as Approve/Done already were. DecisionControl is off the @plannotator/ui host-supported surface, so no package bump.

Test plan

  • bun x tsc --noEmit -p packages/ui/tsconfig.json
  • DOM_TESTS=1 bun test packages/ui packages/editor packages/review-editor

The primary reads Send Feedback / Post Comments with no inline count; the
count stays in the caret menu's discard and note copy where it is needed.
DecisionPrimary loses its count field, tests pin the count-free label, and
the docs no longer spell the control as 'Send Feedback · n'.
@backnotprop
backnotprop merged commit 35c3e2b into main Sep 12, 2026
28 checks passed
@backnotprop
backnotprop deleted the fix/decision-control-no-count branch September 12, 2026 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant