Repository navigation
fix(ui): drop the annotation count pill from the header decision primary - #1516
Merged
Merged
Conversation
The primary reads Send Feedback / Post Comments with no inline count; the count stays in the caret menu's discard and note copy where it is needed. DecisionPrimary loses its count field, tests pin the count-free label, and the docs no longer spell the control as 'Send Feedback · n'.
2 tasks done
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Send Feedback · n(maintainer ruling).DecisionPrimary.countis removed from the pure spec; the annotation count still drives the caret menu's discard and approve-with-notes copy, which is where it is needed.decisionSpec.test.tsand the reviewApp.decisionControlsuite now pin that the primary label carries no digits; AGENTS.md andtests/UI-TESTING.mdstop spelling the control with a count.Below the label breakpoint the primary is icon-only, the same as Approve/Done already were.
DecisionControlis off the@plannotator/uihost-supported surface, so no package bump.Test plan
bun x tsc --noEmit -p packages/ui/tsconfig.jsonDOM_TESTS=1 bun test packages/ui packages/editor packages/review-editor