Repository navigation
Question card: the off decision tag reads as off; the eyebrow pills align - #1816
Merged
Merged
Conversation
…height on one line Measures every question card's eyebrow pills in Chromium (top, bottom and height within 0.5 px) with the on and off tag beside Open, and the on tag beside Answered. Fails against main (Open 19.22 px tall and 2.6 px lower than the 17.22 px decision tag), passes with the shared pill box.
backnotprop
force-pushed
the
fix/question-card-eyebrow
branch
from
October 10, 2026 22:25
a10cc0c to
c5f06d6
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner's screenshot of a question card in the Inbox showed two problems in the card's eyebrow row. This PR fixes both in
packages/ui/components/blocks/QuestionBlock.tsx, so the plan editor, annotate and the Inbox all get the fix. It changes styling only. No prop, attribute or markup changes.1. The off decision tag now reads as off
Off was drawn in
--muted-foreground, which is exactly the color of the "Open" tag next to it. Measured against the card in the default theme, both were 8.98:1 (light) and 7.37:1 (dark), so an off tag looked almost the same as an on one.The off color is now
color-mix(in oklab, var(--muted-foreground) 55%, transparent). The text, the diamond and the dotted outline all usecurrentColor, so they fade together, the same asopacity: 0.55would. Measured against the card, the off tag is now 2.76:1 (light) and 3.06:1 (dark). It does not useopacity, because that would also fade thering-primaryfocus ring, which stays at full strength (see the*-focused-*PNGs). The tag is still a focusable button: the words open the decision card and the diamond is the switch.2. The eyebrow pills now align
Before, "Open" was 19.22 px tall and the decision tag was 17.22 px, because only "Open" had a border. The split tag (diamond switch + words) also sat 1.6 px higher than "Open" and "Skipped": its inline-flex baseline came from the icon-only switch.
Now every pill in the row is the same box: 18 px tall (
h-[18px],leading-4) with a 1 px border, transparent on every tag except "Open". This covers Open, Answered, Settled, Skipped, "Decision", and all three forms of "Records a decision" (split, toggle, static). The pill group is aninline-flex items-center gap-1row. Measured in Chromium in the Inbox, each pair in every state now has the same height (18 px) and the same center.guides.show viewer: unchanged
The viewer's stylesheet scans
packages/ui/components. Removingalign-[1px]changed the viewer CSS, because this file was its only use. I kept that class (it has no effect inside the flex row) and used only classes the viewer already ships.build:viewer+check:manifestreport "in sync", andcheck:budgetspasses. No guides.show deploy is needed. The viewer JS does not includeQuestionBlock.Proof (real Inbox window, compiled binary, temp data dir, Chromium at 3x)
Before and after binaries were built from origin/main and from this branch. Each binary ran
plannotator inbox --backgroundunder a tempPLANNOTATOR_DATA_DIR. An agent sentDEMO_MESSAGES.stoppedplus a second message throughplannotator inbox mcp. In the window, one question was picked (Answered) and one was skipped. The screenshot is the eyebrow row of each card:/tmp/qcard-proof/{before,after}-{light,dark}-2-off-open.png: off tag beside "Open" (the owner's case)/tmp/qcard-proof/{before,after}-{light,dark}-1-on-open.png: on tag beside "Open"/tmp/qcard-proof/{before,after}-{light,dark}-3-decision-settled.png: "Decision" + "Settled"/tmp/qcard-proof/{before,after}-{light,dark}-4-plain-answered.png: off tag + "Answered"/tmp/qcard-proof/{before,after}-{light,dark}-5-on-skipped.png: on tag + "Skipped"/tmp/qcard-proof/{before,after}-{light,dark}-2-off-open-focused-{words,switch}.png: keyboard focus on the off tag; the ring stays at full strength/tmp/qcard-proof/{before,after}-metrics.json: per-pill height, center and color, and the contrast figures aboveTests
DOM_TESTS=1 bun test packages/ui/components/blocks/ packages/ui/components/Viewerpasses (161), as doespackages/inbox. In the two decision-toggle tests, the oldcolor: var(--muted-foreground)assertions are replaced withdata-question-decision-recording="off", and the tests check thatopacitystays unset. happy-dom dropscolor-mix(), so the color itself is checked in Chromium (above), not in the DOM tests.Docs:
packages/ui/HANDOFF.mdhas a new section, "Question card eyebrow", and the two older statements about the off look are corrected. Thepackages/ui/README.mdline is updated.