Repository navigation
Inbox mobile contract: the Android addendum (C2) - #1827
Merged
Merged
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step C2 of the Android plan. A document change only: it adds section 10, "The Android addendum", to
adr/implementation/inbox-mobile.md, so the Android lanes have a written contract to build against, as the iPhone lanes had C1.What the addendum settles for the Android lanes:
platform: "android"and the device record keeps it. The package isai.plannotator.app, and the floor is Android 13 (API 33).PUT .../devices/:dev/fcm, sits beside.../apns. A device holds one push token at a time.hellogainsfcm. The FCM HTTP v1 message is data only ({ "e": "<envelope>" },android.priority: high,collapse_key= the collapse id), so the app draws each notification itself. New push answers:no_fcm_key,fcm_goneand502 fcm_failed. With neither token the relay answersno_push_tokenfrom R3 on; a relay before R3 answersno_apns_token. The Inbox treats both alike (it only logs the reason). The size ladder is unchanged and still measured against the APNs body, which is larger than FCM's data for the same envelope. FCM'sUNREGISTEREDdeletes the token, as Apple's 410 does. The section also covers token refresh (onNewToken, a check at each start,nullwhen notifications are off).setAuthenticationRequired(true). A question with four choices gets one "Answer" action that opens the thread.https://appassets.androidplatform.net(WebViewAssetLoader's virtual origin), not a custom scheme. The reason:addWebMessageListenerorigin rules match only http and https, and the*rule would also give the bridge to the agent's opaque frame. The channel iswindow.plannotatorShell(a JSON string), and the shell takes messages from the main frame only. There is no network, by two means: the CSP on every response, plussetBlockNetworkLoadswithshouldInterceptRequestrefusing every request off the virtual origin. WebSockets do not pass through interception, so they rest onconnect-src 'none'and the blocked loads; the device spike must prove this. The touch window and the link rules carry over.FirebaseMessagingService, and SFSafariViewController becomes Custom Tabs. One line covers the other side: it serves assetlinks.json and sends FCM for its own source.Still pending: the four-choice notification layout. The owner has not ruled yet. The section writes the "Answer" action as the default and notes the alternative, a custom four-button layout.
Checks: gitleaks range scan clean; Semgrep (the pinned CI image,
.semgrep.yml) scanned no targets, which is a pass for a doc change.