Repository navigation
Updates 3/3: review-window notice from the server, the 3-day toast, Pi parity - #1835
Merged
Merged
Conversation
backnotprop
force-pushed
the
feat/updates-inbox
branch
from
October 11, 2026 00:08
4d723ff to
82c9022
Compare
backnotprop
force-pushed
the
feat/updates-review
branch
from
October 11, 2026 00:23
9022c69 to
8f02b71
Compare
backnotprop
force-pushed
the
feat/updates-inbox
branch
from
October 11, 2026 00:27
82c9022 to
98822e6
Compare
backnotprop
force-pushed
the
feat/updates-review
branch
from
October 11, 2026 00:27
8f02b71 to
d40c5ef
Compare
backnotprop
force-pushed
the
feat/updates-review
branch
2 times, most recently
from
October 11, 2026 01:23
171fdea to
b003252
Compare
…oast, Pi parity The browser no longer asks GitHub on every page load. The compiled CLI's plan, review and annotate servers (and Pi's three servers) put updateAvailable on the payload from the machine's once-a-day cache, with the action and command for the host (install command with remembered flags; pi update --extensions on Pi). The toast shows at most once per version and once every three days, behind the first-run dialogs and never over a focused composer; its Update runs POST /api/update (the same install wrapper, once). The Options menu keeps the dot without the shimmer and shows the right command; Settings gains the update-notice switch.
…bs get 409, the guides.show viewer unchanged - POST /api/update refuses any Host that is not loopback with this server's port, refuses a remote-mode or --tailscale session outright, and their advert says copy (the command), so a LAN or tailnet device can never start the installer. The client sends its serverSession; another session's tab gets 409 session_mismatch. - The update-notice switch is no longer a settings-registry entry (useUpdateCheckSetting writes POST /api/config), so the pinned guides.show viewer build is byte-identical: build:viewer then check:manifest is in sync. - Docs: never the browser, Pi as a caller, the review-window notice.
backnotprop
force-pushed
the
feat/updates-review
branch
from
October 11, 2026 01:48
b003252 to
34dbc03
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 3 of the owner-approved update notices (design
.product/approved/plannotator-updates/). Stacked on #1833 (Inbox), which is stacked on #1830 (the check).What it does
The browser no longer asks GitHub.
useUpdateChecklost its per-page-loadfetchofreleases/latest(no throttle, no off switch, and in remote mode a remote browser leakingOrigin: http://localhost:<port>to GitHub). It now takes the server's advert;?preview-update=Xstill simulates one.Servers advertise the answer (cache only, never a network call on a page load):
/api/planand/api/diffcarryupdateAvailable: { version, current, releaseUrl, action, command }(getUpdateAdvert(origin)).action:script(the binary the install script manages),copy(an unmanaged binary),opencode(OpenCode-launched CLI).commandcarries the remembered install flags, so a pasted command no longer resetsinstall-flags.json.action: "pi",command: "pi update --extensions"(was the wrongpi install npm:…), compared with the Pi package's own version; the Pi extension also schedules the shared daily check (vendoredupdate-check). Nothing foroh-my-pi.POST /api/update(Bun plan/review/annotate): the toast's and menu's Update, the samestartManualUpdatewrapper andupdate.lockas the Inbox; same-origin only.The toast (
useUpdateToast): at most once per version and at most once every 3 days across versions (owner's answer 3; cookie shared by every localhost port), first look 5 s after load, queued behind every first-run dialog of the load and never while a composer or dialog has focus (re-checks, unconsumed), never for share links / archive / server-less pages / while auto-update is active. Copy per host from the design; actions What's new · Update (script) or Copy command.Options menu: the dot stays, the label shimmer is gone (no motion); the version section shows "X is available · What's new", the host's command with Copy, and Update now for
script.Settings → General: "Tell me when a new version is out" (
updateCheck, the off switch, owner's answer 1) above "Keep Plannotator up to date", which is locked with "Needs update checks" while checks are off.Tests
packages/ui/utils/updateNotice.test.ts: the 3-day / once-per-version rhythm, advert validation, per-host toast copy (Pi never gets the install script).packages/server/update-advert.test.ts: the advert on plan / annotate / review payloads, absent when checks are off (config or env), up to date, or outside the compiled CLI; host action;POST /api/updaterefuses cross-origin, dev builds, unmanaged binaries, and a second run underupdate.lock.apps/pi-extension/update-advert.test.ts: the Pi mirror.packages/ui/components/MenuVersionSection.test.tsx(DOM): command per host, Update now only forscript.Known gap (design phase 3, not built): OpenCode's in-process embedded plan server sends no advert (it has no version to compare); OpenCode's review/annotate run the CLI and do.