Repository navigation
Inbox: two style clashes from #1838 (sidebar quiet folder, attachment 'changed' line) - #1851
Merged
Merged
Conversation
| const host = document.createElement('div'); | ||
| host.className = 'pn-inbox'; | ||
| document.body.appendChild(host); | ||
| const project = { id: 'prj_q', key: 'quiet-abc123', name: 'quiet', root: '/tmp/quiet', created_at: '2026-10-11T10:00:00.000Z', threads: 1, unread: 0 }; |
… pane's changed line
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1838 added question-card styles under
.pn-inboxthat also matched two unrelated elements:.pn-inbox .ib-q(bordered card, 20px margins) matched the sidebar's quiet project folder, which usedib-qfor 'nothing waiting'. Every project with nothing waiting rendered as a bordered card in the sidebar. Renamed the folder's class toib-proj-quiet..pn-inbox .ib-changed(rounded box, full border, bottom margin) restyled the attachment pane's 'Changed since it was sent' bar (Plannotator Inbox step 2: attachments, versioned, annotated in the Inbox #1759). Renamed the replaced-question notice's class toib-q-changed.New DOM test
packages/inbox/sidebarQuiet.test.tsx(in the test.yml DOM list) fails on main and passes here.replaced.test.tsxpasses. Found by an independent review.