Skip to content

Inbox: two style clashes from #1838 (sidebar quiet folder, attachment 'changed' line) - #1851

Merged
backnotprop merged 2 commits into
mainfrom
fix/inbox-sidebar-quiet-class
Oct 11, 2026
Merged

backnotprop merged 2 commits into
mainfrom
fix/inbox-sidebar-quiet-class

Conversation

@backnotprop

@backnotprop backnotprop commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

#1838 added question-card styles under .pn-inbox that also matched two unrelated elements:

  • .pn-inbox .ib-q (bordered card, 20px margins) matched the sidebar's quiet project folder, which used ib-q for 'nothing waiting'. Every project with nothing waiting rendered as a bordered card in the sidebar. Renamed the folder's class to ib-proj-quiet.
  • .pn-inbox .ib-changed (rounded box, full border, bottom margin) restyled the attachment pane's 'Changed since it was sent' bar (Plannotator Inbox step 2: attachments, versioned, annotated in the Inbox #1759). Renamed the replaced-question notice's class to ib-q-changed.

New DOM test packages/inbox/sidebarQuiet.test.tsx (in the test.yml DOM list) fails on main and passes here. replaced.test.tsx passes. Found by an independent review.

const host = document.createElement('div');
host.className = 'pn-inbox';
document.body.appendChild(host);
const project = { id: 'prj_q', key: 'quiet-abc123', name: 'quiet', root: '/tmp/quiet', created_at: '2026-10-11T10:00:00.000Z', threads: 1, unread: 0 };
@backnotprop backnotprop changed the title Inbox: a quiet project in the sidebar no longer draws as a question card Inbox: two style clashes from #1838 (sidebar quiet folder, attachment 'changed' line) Oct 11, 2026
@backnotprop
backnotprop merged commit 9cf5a9f into main Oct 11, 2026
29 checks passed
@backnotprop
backnotprop deleted the fix/inbox-sidebar-quiet-class branch October 11, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants