Repository navigation
Inbox: shift-click joins more elements to one comment on an attached HTML page - #2019
Merged
Merged
Conversation
…HTML page
The Inbox's attached-page viewer passed maxAdditionalTargets={0}, so the
bridge was armed with a cap of 0 and every shift-click was dropped. It has
been that way since attachments shipped (#1759); not a regression from #2000.
Annotate never set the cap and works. The viewer's own cap (16) now applies.
Co-authored-by: Claude <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shift-click did nothing on an attached HTML page in the Inbox. The pane's
HtmlViewerpassedmaxAdditionalTargets={0}, so the bridge was armed with a cap of 0 and dropped every shift-click. The cap has been there since attachments shipped (#1759), so this is not a regression from #2000. Annotate never set it, and shift-click works there.The fix removes the cap from the attached page's viewer, so the viewer's own cap (16) applies, as in annotate. The read-only linked-page viewer and the phone surface keep 0. The store keeps annotations as they are, and the export already lists the extra elements.
Tests:
packages/inbox/htmlLinks.test.tsx: a pin on the page arms multi-select without a cap of 0, and two added targets make three chips. Fails without the fix.tests/e2e/inbox-html-links.spec.ts: on the compiled binary, click a heading, then shift-click a paragraph and a link. The comment has three targets, the link is not followed, and the saved annotation has twohtmlAdditionalTargets. Fails without the fix.tests/e2e/annotate-html-links.spec.ts: the same flow in annotate's HTML surface (it already passed).🤖 Generated with Claude Code