Skip to content

Inbox: shift-click joins more elements to one comment on an attached HTML page - #2019

Merged
backnotprop merged 1 commit into
mainfrom
html-shift-click
Oct 20, 2026
Merged

backnotprop merged 1 commit into
mainfrom
html-shift-click

Conversation

@backnotprop

Copy link
Copy Markdown
Owner

Shift-click did nothing on an attached HTML page in the Inbox. The pane's HtmlViewer passed maxAdditionalTargets={0}, so the bridge was armed with a cap of 0 and dropped every shift-click. The cap has been there since attachments shipped (#1759), so this is not a regression from #2000. Annotate never set it, and shift-click works there.

The fix removes the cap from the attached page's viewer, so the viewer's own cap (16) applies, as in annotate. The read-only linked-page viewer and the phone surface keep 0. The store keeps annotations as they are, and the export already lists the extra elements.

Tests:

  • packages/inbox/htmlLinks.test.tsx: a pin on the page arms multi-select without a cap of 0, and two added targets make three chips. Fails without the fix.
  • tests/e2e/inbox-html-links.spec.ts: on the compiled binary, click a heading, then shift-click a paragraph and a link. The comment has three targets, the link is not followed, and the saved annotation has two htmlAdditionalTargets. Fails without the fix.
  • tests/e2e/annotate-html-links.spec.ts: the same flow in annotate's HTML surface (it already passed).
  • Typecheck passes. The html-viewer DOM tests and the full html-links e2e specs pass.

🤖 Generated with Claude Code

…HTML page

The Inbox's attached-page viewer passed maxAdditionalTargets={0}, so the
bridge was armed with a cap of 0 and every shift-click was dropped. It has
been that way since attachments shipped (#1759); not a regression from #2000.
Annotate never set the cap and works. The viewer's own cap (16) now applies.

Co-authored-by: Claude <noreply@anthropic.com>
@backnotprop
backnotprop merged commit 1f3419e into main Oct 20, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant