Repository navigation
fix(annotate): keep Contents in sync after scrolling and file switches - #2403
Merged
backnotprop merged 1 commit intoNov 1, 2026
Merged
backnotprop merged 1 commit into
backnotprop merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contents could remain several sections behind after a large scroll. Switching to another document with the same heading count could leave it tracking the previous document's heading elements.
Replace the intersection-based tracking with current heading positions at the 80px reading line. Scroll updates are coalesced into one animation frame, and content mutations and resizes refresh the active section.
Update the focused tests for large jumps, reverse scrolling, same-count document replacement, and empty content. Remove the unused intersection-observer test helper.
Closes #2231.
Verification
DOM_TESTS=1 bun test \ packages/ui/hooks/useScrollViewport.test.ts \ packages/ui/hooks/useActiveSection.test.tsx \ packages/ui/hooks/useActiveSection.positions.test.tsx \ packages/editor/App.bundle.test.tsx bun x tsc --noEmit -p packages/ui/tsconfig.json bun run --cwd apps/hook vite build git diff --check