Skip to content

refactor(create-pr): improve skill per writing-skills guidelines - #199

Merged
baleen37 merged 2 commits into
mainfrom
refactor/create-pr-skill-improvements
Jan 27, 2026
Merged

refactor(create-pr): improve skill per writing-skills guidelines#199
baleen37 merged 2 commits into
mainfrom
refactor/create-pr-skill-improvements

Conversation

@baleen37

@baleen37 baleen37 commented Jan 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • Fix description to focus on triggers only (CSO compliance)
  • Remove unsupported user-invocable frontmatter field
  • Add graphviz flowchart for workflow visualization
  • Consolidate Quick Reference into table format
  • Remove redundant Workflow section, keep Key Decision Points
  • Clarify Arguments section
  • Remove TDD-VALIDATION.md (not practical, adds maintenance burden)

Word count reduced from ~800 to ~700 words.

Test plan

  • BATS tests pass
  • Skill loads correctly in Claude Code

Summary by CodeRabbit

  • Documentation
    • Enhanced create-pr skill documentation with comprehensive workflow diagrams, detailed decision points for base branch detection and conflict resolution, expanded quick reference guide, and improved step-by-step instructions for PR lifecycle management.
    • Removed validation testing documentation.

✏️ Tip: You can customize this high-level summary in your review settings.

baleen37 and others added 2 commits January 27, 2026 15:03
- Add post-creation PR status check (mergeStateStatus)
- Auto-update branch when BEHIND base
- Auto-resolve simple conflicts (whitespace, imports)
- Add rationalization table for common excuses
- Update red flags to include post-PR violations

Closes user-reported issue: PR created but needs update branch or has conflicts.

TDD-validated: 4 gaps identified and closed, 5 rationalization patterns blocked.

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Fix description to focus on triggers only (CSO compliance)
- Remove unsupported user-invocable frontmatter field
- Add graphviz flowchart for workflow visualization
- Consolidate Quick Reference into table format
- Remove redundant Workflow section, keep Key Decision Points
- Clarify Arguments section
- Remove TDD-VALIDATION.md (not practical, adds maintenance burden)

Word count reduced from ~800 to ~700 words.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@baleen37
baleen37 enabled auto-merge (squash) January 27, 2026 06:10
@coderabbitai

coderabbitai Bot commented Jan 27, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This pull request substantially refactors documentation for the create-pr skill. SKILL.md is rewritten with expanded workflow guidance, including new sections for workflow overview, key decision points, and detailed workflow decisions. TDD-VALIDATION.md is removed entirely. No code or API changes are introduced.

Changes

Cohort / File(s) Summary
Documentation Refactor
plugins/me/skills/create-pr/SKILL.md
Substantially rewritten workflow documentation: adds Graphviz workflow diagram, expands "Red Flags - STOP" section, replaces Quick Reference with comprehensive table, introduces Key Decision Points subsection, adds detailed Workflow Decision sections, updates PR Body Template, restructures Common Mistakes section, adds Rationalization Table, clarifies Arguments with supported flags and examples.
Documentation Deletion
plugins/me/skills/create-pr/TDD-VALIDATION.md
Entire TDD validation report file removed (previously contained multi-phase validation workflow, metrics, gaps, verification tests, adversarial hardening tests, comparison with original skill, and deployment status).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • PR #195: Overlapping edits to the same create-pr skill documentation files (SKILL.md, TDD-VALIDATION.md) with conflicting changes across both PRs.
  • PR #193: Modifies create-pr skill's SKILL.md with reworked base-branch detection, conflict-check/update steps, and PR/merge guidance.
  • PR #181: Removes now-redundant command wrapper that depends on the create-pr skill being documented.

Suggested labels

released

Poem

🐰 ✨ A skill reborn in words so clear,
Diagrams guide the workflow dear,
Decision points and red flags bright,
The create-PR shines with new light!
Old tests rest, new docs take flight! 📝


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@baleen37
baleen37 merged commit e842954 into main Jan 27, 2026
1 of 2 checks passed
@baleen37
baleen37 deleted the refactor/create-pr-skill-improvements branch January 27, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant