test(ralph-loop): add comprehensive unit tests for state library - #207
Merged
Conversation
Add unit tests for: - state.sh library functions (validate_session_id, parse_frontmatter, get_iteration, get_max_iterations, get_completion_promise) - Completion promise tag extraction verification - Multibyte character handling (UTF-8, emoji) - Edge cases (empty values, special chars, dashes in prompt) Also fix existing session_id sanitization tests to check for validate_session_id function calls instead of direct regex patterns. Co-Authored-By: Claude <noreply@anthropic.com>
baleen37
force-pushed
the
chore/remove-loop
branch
from
January 29, 2026 02:40
333c101 to
ef4c928
Compare
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR adds comprehensive unit tests for the ralph-loop plugin, verifying session validation, YAML parsing, iteration tracking, promise extraction, and edge cases including UTF-8/emoji handling and special characters across multiple shell scripts. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Jan 30, 2026
Merged
This was referenced Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state.shlibrary functionsTest plan
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.