refactor(me): rename docker-sandbox to claude-isolated-test - #218
Conversation
The docker-sandbox skill was previously located in /skills/docker-sandbox,
which is not a valid location for Claude to recognize skills. Skills must
be located within a plugin directory (plugins/{name}/skills/).
This commit moves the docker-sandbox skill into the me plugin so it can
be properly discovered and used by Claude Code.
Co-Authored-By: Claude <noreply@anthropic.com>
Rename the skill to better reflect its purpose: testing Claude Code components in isolated Docker environments. The new name emphasizes the goal (isolated testing) rather than the implementation (Docker). Co-Authored-By: Claude <noreply@anthropic.com>
- Fix comparison table header in SKILL.md - Fix hardcoded path in run-docker-test.sh (use relative path) Co-Authored-By: Claude <noreply@anthropic.com>
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe PR renames the docker-sandbox skill to claude-isolated-test, updates the docker build context path in the run script, and removes two helper shell scripts (docker-helpers.sh and test-helpers.sh) that provided Docker lifecycle management and test utilities. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
- Rename test file: docker-sandbox.bats → claude-isolated-test.bats - Update path: skills/docker-sandbox → plugins/me/skills/claude-isolated-test - Update variable: DOCKER_SANDBOX_DIR → CLAUDE_ISOLATED_TEST_DIR Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (4)
plugins/me/skills/claude-isolated-test/SKILL.md (2)
293-293:⚠️ Potential issue | 🟡 MinorTypo in shebang within documentation code block.
The shebang
#!/usr/bashis incorrect and may mislead users copying this example. It should be#!/usr/bin/bashor preferably#!/usr/bin/env bashfor portability.📝 Proposed fix
-#!/usr/bash +#!/usr/bin/env bash
121-215:⚠️ Potential issue | 🔴 CriticalHelper library files documented in SKILL.md do not exist.
The SKILL.md references implementations from
scripts/lib/docker-helpers.shandscripts/lib/test-helpers.sh, but these files do not exist anywhere in the repository. The skill directory contains only:
docker/Dockerfilescripts/run-docker-test.sh- Test files in
tests/The code blocks showing full implementations of helper functions (lines 121–215 and 217–288) document files that are missing, making the documentation misleading. Either add the actual helper files at these locations or update the documentation to accurately reflect the implementation.
plugins/me/skills/claude-isolated-test/scripts/run-docker-test.sh (2)
10-11:⚠️ Potential issue | 🔴 CriticalThe sourced helper libraries do not exist and will cause immediate script failure.
The
docker-helpers.shandtest-helpers.shfiles are missing from the repository. The expectedlibdirectory atplugins/me/skills/claude-isolated-test/scripts/lib/does not exist. Since the script hasset -euo pipefailenabled, thesourcecommands on lines 10-11 will fail immediately, preventing the script from executing.These missing files define critical functions that the script depends on (
load_test_definition,check_docker_available,build_claude_image,cleanup_container,create_container,wait_for_claude_ready,get_container_logs,exec_in_container_capture,verify_contains,report_result, andskip). Restore these helper files or provide their implementations.
110-119:⚠️ Potential issue | 🔴 CriticalHelper libraries are missing and
TEST_EXPECTED_CONTAINSis not populated.The script sources
$SCRIPT_DIR/lib/docker-helpers.shand$SCRIPT_DIR/lib/test-helpers.sh(lines 10-11) which do not exist in the repository. Additionally, the documentedload_test_definitionfunction in SKILL.md (lines 226-235) does not extract theexpected_output.containsfield from the YAML test format, soTEST_EXPECTED_CONTAINSarray is never initialized. The script will fail immediately at runtime due toset -euo pipefailwhen trying to source these missing files, and even if they existed, the function would not populate the array used at lines 110 and 113.
🧹 Nitpick comments (1)
plugins/me/skills/claude-isolated-test/scripts/run-docker-test.sh (1)
7-7:PROJECT_ROOTis now dead code.After the path change on line 64,
PROJECT_ROOTis no longer referenced anywhere in the script. Consider removing this unused variable.🧹 Proposed fix to remove dead code
# Script directory SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" -PROJECT_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"
- Add scripts/lib/ directory with helper scripts that were missed in rename - Update .gitignore: change lib/ to */lib/ to allow exception patterns to work This fixes CI failures where docker-helpers.sh and test-helpers.sh could not be found. Co-Authored-By: Claude <noreply@anthropic.com>
Summary
docker-sandboxskill toclaude-isolated-testto better reflect its purpose: testing Claude Code components in isolated Docker environmentsskills/directory toplugins/me/skills/so Claude can properly discover itChanges
skills/docker-sandbox/→plugins/me/skills/claude-isolated-test/name: docker-sandbox→name: claude-isolated-testDocker Sandbox Testing→Claude Isolated Testing$SCRIPT_DIR/../dockerin test scriptTest plan
docker-sandboxreferences replaced withclaude-isolated-test🤖 Generated with Claude Code
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.