Skip to content

refactor(me): rename docker-sandbox to claude-isolated-test - #218

Merged
baleen37 merged 6 commits into
mainfrom
refactor/claude-isolated-test-rename
Jan 31, 2026
Merged

refactor(me): rename docker-sandbox to claude-isolated-test#218
baleen37 merged 6 commits into
mainfrom
refactor/claude-isolated-test-rename

Conversation

@baleen37

@baleen37 baleen37 commented Jan 31, 2026

Copy link
Copy Markdown
Owner

Summary

  • Rename docker-sandbox skill to claude-isolated-test to better reflect its purpose: testing Claude Code components in isolated Docker environments
  • Move skill from root skills/ directory to plugins/me/skills/ so Claude can properly discover it
  • Update all references including documentation and script paths

Changes

  1. Move location: skills/docker-sandbox/plugins/me/skills/claude-isolated-test/
  2. Rename skill: name: docker-sandboxname: claude-isolated-test
  3. Update title: Docker Sandbox TestingClaude Isolated Testing
  4. Fix hardcoded path: Use relative path $SCRIPT_DIR/../docker in test script

Test plan

  • Skill file structure is valid (SKILL.md exists with frontmatter)
  • All docker-sandbox references replaced with claude-isolated-test
  • Script paths use portable relative paths
  • Verify skill is discoverable by Claude Code after merge

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Renamed the docker-sandbox skill to claude-isolated-test, updating related documentation and configuration references.
    • Reorganized internal testing and helper infrastructure to streamline the build process.

✏️ Tip: You can customize this high-level summary in your review settings.

baleen37 and others added 3 commits January 31, 2026 09:57
The docker-sandbox skill was previously located in /skills/docker-sandbox,
which is not a valid location for Claude to recognize skills. Skills must
be located within a plugin directory (plugins/{name}/skills/).

This commit moves the docker-sandbox skill into the me plugin so it can
be properly discovered and used by Claude Code.

Co-Authored-By: Claude <noreply@anthropic.com>
Rename the skill to better reflect its purpose: testing Claude Code
components in isolated Docker environments. The new name emphasizes
the goal (isolated testing) rather than the implementation (Docker).

Co-Authored-By: Claude <noreply@anthropic.com>
- Fix comparison table header in SKILL.md
- Fix hardcoded path in run-docker-test.sh (use relative path)

Co-Authored-By: Claude <noreply@anthropic.com>
@baleen37
baleen37 enabled auto-merge January 31, 2026 01:01
@coderabbitai

coderabbitai Bot commented Jan 31, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@baleen37 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 31 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📝 Walkthrough

Walkthrough

The PR renames the docker-sandbox skill to claude-isolated-test, updates the docker build context path in the run script, and removes two helper shell scripts (docker-helpers.sh and test-helpers.sh) that provided Docker lifecycle management and test utilities.

Changes

Cohort / File(s) Summary
Skill Rename
plugins/me/skills/claude-isolated-test/SKILL.md, plugins/me/skills/claude-isolated-test/scripts/run-docker-test.sh
Updated skill name from docker-sandbox to claude-isolated-test; revised docker build context path from $PROJECT_ROOT/skills/docker-sandbox/docker to $SCRIPT_DIR/../docker.
Docker Utilities Removal
skills/docker-sandbox/scripts/lib/docker-helpers.sh, skills/docker-sandbox/scripts/lib/test-helpers.sh
Deleted docker-helpers.sh containing 10 Docker lifecycle functions (check_docker_available, _build_claude_image, create_container, exec_in_container, wait_for_claude_ready, etc.). Deleted test-helpers.sh with test utilities including YAML test loading, output verification, container state validation, and result reporting.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Poem

🐰 A rabbit hops through docker lanes,
Renaming skills from old chains,
Helpers cleaned, the path runs true,
Claude-isolated-test shines anew! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main refactoring objective: renaming the docker-sandbox skill to claude-isolated-test. It directly corresponds to the primary change in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/claude-isolated-test-rename

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

- Rename test file: docker-sandbox.bats → claude-isolated-test.bats
- Update path: skills/docker-sandbox → plugins/me/skills/claude-isolated-test
- Update variable: DOCKER_SANDBOX_DIR → CLAUDE_ISOLATED_TEST_DIR

Co-Authored-By: Claude <noreply@anthropic.com>

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (4)
plugins/me/skills/claude-isolated-test/SKILL.md (2)

293-293: ⚠️ Potential issue | 🟡 Minor

Typo in shebang within documentation code block.

The shebang #!/usr/bash is incorrect and may mislead users copying this example. It should be #!/usr/bin/bash or preferably #!/usr/bin/env bash for portability.

📝 Proposed fix
-#!/usr/bash
+#!/usr/bin/env bash

121-215: ⚠️ Potential issue | 🔴 Critical

Helper library files documented in SKILL.md do not exist.

The SKILL.md references implementations from scripts/lib/docker-helpers.sh and scripts/lib/test-helpers.sh, but these files do not exist anywhere in the repository. The skill directory contains only:

  • docker/Dockerfile
  • scripts/run-docker-test.sh
  • Test files in tests/

The code blocks showing full implementations of helper functions (lines 121–215 and 217–288) document files that are missing, making the documentation misleading. Either add the actual helper files at these locations or update the documentation to accurately reflect the implementation.

plugins/me/skills/claude-isolated-test/scripts/run-docker-test.sh (2)

10-11: ⚠️ Potential issue | 🔴 Critical

The sourced helper libraries do not exist and will cause immediate script failure.

The docker-helpers.sh and test-helpers.sh files are missing from the repository. The expected lib directory at plugins/me/skills/claude-isolated-test/scripts/lib/ does not exist. Since the script has set -euo pipefail enabled, the source commands on lines 10-11 will fail immediately, preventing the script from executing.

These missing files define critical functions that the script depends on (load_test_definition, check_docker_available, build_claude_image, cleanup_container, create_container, wait_for_claude_ready, get_container_logs, exec_in_container_capture, verify_contains, report_result, and skip). Restore these helper files or provide their implementations.


110-119: ⚠️ Potential issue | 🔴 Critical

Helper libraries are missing and TEST_EXPECTED_CONTAINS is not populated.

The script sources $SCRIPT_DIR/lib/docker-helpers.sh and $SCRIPT_DIR/lib/test-helpers.sh (lines 10-11) which do not exist in the repository. Additionally, the documented load_test_definition function in SKILL.md (lines 226-235) does not extract the expected_output.contains field from the YAML test format, so TEST_EXPECTED_CONTAINS array is never initialized. The script will fail immediately at runtime due to set -euo pipefail when trying to source these missing files, and even if they existed, the function would not populate the array used at lines 110 and 113.

🧹 Nitpick comments (1)
plugins/me/skills/claude-isolated-test/scripts/run-docker-test.sh (1)

7-7: PROJECT_ROOT is now dead code.

After the path change on line 64, PROJECT_ROOT is no longer referenced anywhere in the script. Consider removing this unused variable.

🧹 Proposed fix to remove dead code
 # Script directory
 SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-PROJECT_ROOT="$(cd "$SCRIPT_DIR/../.." && pwd)"

baleen37 and others added 2 commits January 31, 2026 10:05
- Add scripts/lib/ directory with helper scripts that were missed in rename
- Update .gitignore: change lib/ to */lib/ to allow exception patterns to work

This fixes CI failures where docker-helpers.sh and test-helpers.sh
could not be found.

Co-Authored-By: Claude <noreply@anthropic.com>
@baleen37
baleen37 merged commit 94e3294 into main Jan 31, 2026
2 checks passed
@baleen37
baleen37 deleted the refactor/claude-isolated-test-rename branch January 31, 2026 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant