Skip to content

refactor: migrate conversation-memory to me plugin - #423

Merged
baleen37 merged 1 commit into
mainfrom
feat/migrate-conversation-memory-to-me-plugin
Feb 5, 2026
Merged

refactor: migrate conversation-memory to me plugin#423
baleen37 merged 1 commit into
mainfrom
feat/migrate-conversation-memory-to-me-plugin

Conversation

@baleen37

@baleen37 baleen37 commented Feb 5, 2026

Copy link
Copy Markdown
Owner

Summary

  • Migrates conversation-memory functionality into me plugin as skill-only component
  • Removes standalone plugin infrastructure (MCP server, CLI, hooks)
  • Adds vitest testing framework for TypeScript-based tests
  • Consolidates into simpler skill-based approach

Test plan

  • All BATS tests pass
  • New vitest test passes
  • Pre-commit hooks pass
  • Pre-push hooks pass
  • CI passes on GitHub

🤖 Generated with Claude Code

Summary by CodeRabbit

Release Notes

  • Breaking Changes

    • Removed conversation-memory plugin and all associated functionality.
  • Documentation

    • Added comprehensive guide for the remembering-conversations skill, including workflow patterns and best practices.
  • Chores

    • Migrated test infrastructure to Vitest framework with updated testing utilities and configuration.

Migrates conversation-memory functionality into me plugin as a skill-only component. Removes the standalone plugin infrastructure (MCP server, CLI, hooks) and consolidates into a simpler skill-based approach.

Changes:
- Remove plugins/conversation-memory plugin entirely
- Add plugins/me/skills/remembering-conversations/SKILL.md
- Add vitest testing framework with helpers
- Add vitest migration patterns documentation
- Update package.json dependencies for vitest
- Remove conversation-memory from marketplace.json

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Feb 5, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR removes the entire conversation-memory plugin and its infrastructure while establishing a Vitest-based testing framework. It adds test helpers, plugin manifest validation, and migration documentation for transitioning from BATS to Vitest. The marketplace.json is updated to remove the conversation-memory entry, and a new skill documentation is introduced.

Changes

Cohort / File(s) Summary
Plugin Removal: conversation-memory
plugins/conversation-memory/...
Deleted entire plugin directory including source code (src/cli/, src/core/, src/mcp/), configuration (.claude-plugin/plugin.json, .mcp.json), build artifacts (scripts/build.mjs, scripts/mcp-server-wrapper.mjs), hooks (hooks/hooks.json, hooks/ensure-deps.sh), package manifest, tests (.bats files), documentation (README.md, agents/, commands/, skills/*), and TypeScript configuration.
Marketplace & Plugin Configuration
.claude-plugin/marketplace.json, plugins/me/skills/remembering-conversations/SKILL.md
Removed conversation-memory plugin entry from marketplace.json; added new skill documentation for remembering-conversations defining usage workflow and search strategy.
Testing Infrastructure Setup
vitest.config.ts, tests/helpers/vitest.ts, package.json
Introduced Vitest configuration with global APIs and path aliases; added comprehensive test helper module with validation/assertion functions, manifest parsing interfaces (PluginManifest, MarketplaceManifest, HooksManifest), and plugin discovery utilities; updated package.json with new test scripts (test, test:run, test:ui, test:bats, test:coverage) and devDependencies (@vitest/ui, vitest, gray-matter, yaml).
Test Migration Documentation
docs/VITEST_MIGRATION_PATTERNS.md
Added comprehensive migration guide documenting BATS-to-Vitest translation patterns across file structure, imports, setup/teardown, assertions, JSON validation, regex matching, and loops; includes helper function mapping table and Phase 1 PoC details for plugin_json.bats migration.
New Test Suites
tests/plugin_json.test.ts
Introduced Vitest-based test suite validating all plugin.json manifests for existence, JSON validity, required fields (name, description, author), naming conventions, non-empty values, and allowed field usage.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

  • PR #357: Directly related — both PRs modify plugins/conversation-memory/commands/search-conversation.md; main PR deletes while #357 modifies it.
  • PR #373: Directly related — both PRs touch conversation-memory build artifacts and configuration (.mcp.json, scripts/mcp-server-wrapper.mjs, README); main PR removes while #373 updates them.
  • PR #363: Related — both PRs touch conversation-memory source files (embeddings.ts, db.ts, package.json) that require coordinated changes.

Suggested labels

enhancement, testing

Poem

🐰 The conversation keeper fades away,
While Vitest helpers bloom and sway,
From BATS to bright new testing ways,
The warren builds for modern days,
With manifests and schemas clear,
A testing future draws quite near! ✨

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/migrate-conversation-memory-to-me-plugin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@baleen37
baleen37 enabled auto-merge (squash) February 5, 2026 10:56
@baleen37
baleen37 merged commit 7a41004 into main Feb 5, 2026
4 of 5 checks passed
@baleen37
baleen37 deleted the feat/migrate-conversation-memory-to-me-plugin branch February 5, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant