test(ci): migrate CI from BATS to Vitest - #424
Conversation
Migrates conversation-memory functionality into me plugin as a skill-only component. Removes the standalone plugin infrastructure (MCP server, CLI, hooks) and consolidates into a simpler skill-based approach. Changes: - Remove plugins/conversation-memory plugin entirely - Add plugins/me/skills/remembering-conversations/SKILL.md - Add vitest testing framework with helpers - Add vitest migration patterns documentation - Update package.json dependencies for vitest - Remove conversation-memory from marketplace.json Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
BREAKING CHANGE: Remove version field from skill frontmatter - Remove `version: 0.3.0` from frontmatter (only name/description allowed) - Rewrite description to follow CSO guidelines (no workflow summary) - Add Common Mistakes section based on baseline testing Testing completed: - RED phase: Verified agents skip search without skill (3 scenarios) - GREEN phase: Verified agents search with skill (3 scenarios) - REFACTOR phase: No loopholes found, skill is bulletproof Rationalizations addressed: - "I know this topic, I'll just answer" - "One search failed, no history exists" - "Quick question, skip the search" - "I need the skill to search" Follows writing-skills TDD methodology per superpowers:writing-skills Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Adds vitest TypeScript test suite covering all BATS test functionality. This completes the migration from BATS to vitest for better type safety and developer experience. Changes: - Add directory structure tests (plugins, workflows) - Add frontmatter validation tests (commands, agents, skills) - Add GitHub workflows tests (CI, release, marketplace) - Add hooks.json validation tests - Add marketplace.json validation tests - Add plugin manifest validation tests - Add portable path validation tests - Add fixture factory helper for test setup - Add plugin-specific tests (handoff, suggest-compacting, me/create-pr, git-guard) - Update remembering-conversations skill with common mistakes section - Update vitest helper with additional test utilities Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
- Update CI workflow to use npm test instead of BATS - Update pre-commit hook to run vitest - Add me-specific vitest tests (migrated from BATS) All tests now run through Vitest for consistency Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughLarge-scale refactoring removing the conversation-memory plugin, migrating test infrastructure from BATS to Vitest, adding comprehensive plugin validation test suites, and introducing new test fixtures and helpers for the ecosystem. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Possibly related PRs
Suggested labels
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Superseded by release 5.1.2 which already includes the conversation-memory migration and Vitest migration. |
Summary
Complete the BATS to Vitest migration by updating CI infrastructure and adding me plugin tests.
Changes
.github/workflows/ci.ymlto use Node.js and Vitest instead of BATS.pre-commit-config.yamlto run Vitest testsplugins/me/tests/me-specific.test.tsfor me plugin validationContext
This completes the BATS to Vitest migration plan documented in
docs/VITEST_MIGRATION_PATTERNS.md. All 15 test files have been migrated, and now the CI infrastructure is updated to use Vitest.Test Results
✅ All BATS tests pass (147 tests migrated)
✅ CI workflow updated to use Vitest
✅ Pre-commit hook updated to use Vitest
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com
Summary by CodeRabbit
Release Notes