remove(notify-user-input): remove non-functional plugin - #448
Merged
Conversation
Remove the notify-user-input plugin due to incompatibility with Claude Code's PreToolUse hook system for AskUserQuestion tool. Root cause: PreToolUse hooks do not work correctly with AskUserQuestion tool (known Claude Code bug: #12031, #13439). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe notify-user-input plugin has been completely removed from the codebase. This includes deletion of the marketplace entry, plugin manifest, configuration files, shell scripts, and documentation, eliminating all references to the macOS notification feature. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
notify-user-inputplugin due to incompatibility with Claude Code's PreToolUse hook systemAskUserQuestiontoolRoot Cause
Claude Code has a known bug where PreToolUse hooks interfere with
AskUserQuestiontool execution:Additionally, the original script had an incorrect JSON path (
.questions[0].textvs.tool_input.questions[0].text), but even with this fix, the PreToolUse hook is not triggered for AskUserQuestion events.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit