Skip to content

remove(notify-user-input): remove non-functional plugin - #448

Merged
baleen37 merged 1 commit into
mainfrom
fix/notify
Feb 8, 2026
Merged

remove(notify-user-input): remove non-functional plugin#448
baleen37 merged 1 commit into
mainfrom
fix/notify

Conversation

@baleen37

@baleen37 baleen37 commented Feb 8, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove notify-user-input plugin due to incompatibility with Claude Code's PreToolUse hook system
  • The plugin cannot function because PreToolUse hooks do not work correctly with the AskUserQuestion tool

Root Cause

Claude Code has a known bug where PreToolUse hooks interfere with AskUserQuestion tool execution:

Additionally, the original script had an incorrect JSON path (.questions[0].text vs .tool_input.questions[0].text), but even with this fix, the PreToolUse hook is not triggered for AskUserQuestion events.

Test plan

  • Plugin removed from marketplace.json
  • All plugin files deleted
  • Commit message follows conventional commits format

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Removals
    • The notify-user-input plugin, which provided macOS desktop notifications when Claude Code requests user input, has been removed.

Remove the notify-user-input plugin due to incompatibility with
Claude Code's PreToolUse hook system for AskUserQuestion tool.

Root cause: PreToolUse hooks do not work correctly with
AskUserQuestion tool (known Claude Code bug: #12031, #13439).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Feb 8, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The notify-user-input plugin has been completely removed from the codebase. This includes deletion of the marketplace entry, plugin manifest, configuration files, shell scripts, and documentation, eliminating all references to the macOS notification feature.

Changes

Cohort / File(s) Summary
Marketplace & Plugin Metadata
.claude-plugin/marketplace.json, plugins/notify-user-input/.claude-plugin/plugin.json
Removed plugin registry entry and manifest file for notify-user-input plugin, including name, version, description, and author metadata.
Plugin Documentation
plugins/notify-user-input/README.md
Deleted user-facing documentation describing the macOS notification feature, installation, and testing instructions.
Hook Configuration & Implementation
plugins/notify-user-input/hooks/hooks.json, plugins/notify-user-input/hooks/ask-user-question.sh
Removed hooks configuration and Bash script that triggered macOS notifications via AppleScript when Claude Code requested user input.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A plugin bids farewell today,
No more notifications on macOS display,
Notifications retire with grace,
As we clean up this feature's space,
One less hook to ask and wait!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/notify

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@baleen37
baleen37 merged commit e18277b into main Feb 8, 2026
4 of 5 checks passed
@baleen37
baleen37 deleted the fix/notify branch February 8, 2026 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant