Skip to content

chore: remove dead code and excessive test files - #516

Merged
baleen37 merged 1 commit into
mainfrom
chore/remove-dead-code-and-excessive-tests
Feb 21, 2026
Merged

chore: remove dead code and excessive test files#516
baleen37 merged 1 commit into
mainfrom
chore/remove-dead-code-and-excessive-tests

Conversation

@baleen37

@baleen37 baleen37 commented Feb 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Remove unused dead code: dist/, 중복 스크립트, 미사용 hooks
  • Remove excessive test files: 메타 테스트, assertion 테스트, 단순 구조 테스트
  • Consolidate 18개의 prompt.md 개별 테스트를 1개로 통합
  • Remove unused helper functions in bats_helper.bash

Test plan

  • 로컬 테스트 통과 확인 (bats tests/)
  • CI 테스트 통과 확인 필요

Summary by CodeRabbit

  • Chores
    • Removed unused development automation scripts and associated test suites.
    • Consolidated test logic and simplified test helper infrastructure.

Removed unused files:
- dist/ directory (Bun runs .ts files directly)
- scripts/check-conflicts.sh (duplicate of skills/create-pr version)
- scripts/verify-pr-status.sh (duplicate of skills/create-pr version)
- scripts/sync-marketplace-version.sh (handled by semantic-release)
- hooks/pre-commit-guard.sh (not referenced in hooks.json)

Removed excessive test files:
- tests/fixture_factory.bats (meta-tests for test utilities)
- tests/new_assertions.bats (tests for assertion helpers)
- tests/directory_structure.bats (only checks directory existence)
- tests/performance/benchmarks.bats (arbitrary performance targets)

Refactored:
- Consolidated 18 prompt.md tests into 1 comprehensive test
- Removed unused get_all_plugins() and clear_plugin_json_cache()
- Removed dead _CACHED_PLUGIN_LIST variable and setup code
@coderabbitai

coderabbitai Bot commented Feb 21, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR removes multiple shell scripts (pre-commit guard, conflict detection, PR status verification, marketplace syncing), associated test files (directory structure, fixture factory, assertions, performance benchmarks), and test helper infrastructure, while consolidating test logic for prompt template validation into a single comprehensive assertion.

Changes

Cohort / File(s) Summary
Shell Scripts Removal
hooks/pre-commit-guard.sh, scripts/check-conflicts.sh, scripts/sync-marketplace-version.sh, scripts/verify-pr-status.sh
Deleted four shell scripts that provided pre-commit hooks, conflict detection, PR status verification with retry logic, and marketplace version synchronization functionality.
Test Files Removal
tests/directory_structure.bats, tests/fixture_factory.bats, tests/new_assertions.bats, tests/performance/benchmarks.bats
Removed four Bats test suites covering directory structure validation, fixture factory CLI tests, new assertion helper validation, and performance benchmarking across parsing and file operations.
Test Infrastructure Updates
tests/helpers/bats_helper.bash
Removed global plugin list caching infrastructure, including _CACHED_PLUGIN_LIST variable, get_all_plugins function, and clear_plugin_json_cache function; cache initialization removed from test setup.
Test Modifications
tests/git-guard/git-guard-specific.bats, tests/ralph_loop_script_tests.bats
Removed pre-commit-guard.sh existence checks from git-guard tests; consolidated prompt template placeholder assertions from multiple granular tests into single comprehensive test.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • PR #509: Removes the same dead/duplicate scripts and hooks, directly related cleanup effort.
  • PR #501: Deletes overlapping hooks and scripts (pre-commit-guard.sh, check-conflicts.sh, verify-pr-status.sh) and related test/helper logic.
  • PR #496: Removes git-guard plugin/hooks and same shell utilities (check-conflicts.sh, verify-pr-status.sh), consolidating commit-guard hook logic.

Poem

🐰 Shell scripts vanish in the night,
Tests simplify, our code grows light!
Caches cleared, hooks retired with grace—
A cleaner repo finds its place. ✨

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/remove-dead-code-and-excessive-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@baleen37
baleen37 merged commit fe55706 into main Feb 21, 2026
4 of 5 checks passed
@baleen37
baleen37 deleted the chore/remove-dead-code-and-excessive-tests branch February 21, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant