chore: remove dead code and excessive test files - #516
Conversation
Removed unused files: - dist/ directory (Bun runs .ts files directly) - scripts/check-conflicts.sh (duplicate of skills/create-pr version) - scripts/verify-pr-status.sh (duplicate of skills/create-pr version) - scripts/sync-marketplace-version.sh (handled by semantic-release) - hooks/pre-commit-guard.sh (not referenced in hooks.json) Removed excessive test files: - tests/fixture_factory.bats (meta-tests for test utilities) - tests/new_assertions.bats (tests for assertion helpers) - tests/directory_structure.bats (only checks directory existence) - tests/performance/benchmarks.bats (arbitrary performance targets) Refactored: - Consolidated 18 prompt.md tests into 1 comprehensive test - Removed unused get_all_plugins() and clear_plugin_json_cache() - Removed dead _CACHED_PLUGIN_LIST variable and setup code
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThis PR removes multiple shell scripts (pre-commit guard, conflict detection, PR status verification, marketplace syncing), associated test files (directory structure, fixture factory, assertions, performance benchmarks), and test helper infrastructure, while consolidating test logic for prompt template validation into a single comprehensive assertion. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
dist/, 중복 스크립트, 미사용 hooksTest plan
bats tests/)Summary by CodeRabbit