feat(skills): add pr-pass skill and refactor create-pr workflow - #540
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughDocumentation updates to the create-pr skill workflow and script, plus introduction of a new pr-pass skill. The create-pr skill now emphasizes step-by-step PR creation with integrated verification checks and delegates broken-state fixes to me:pr-pass. The verify-pr-status.sh script replaces remote script invocations with inline git commands. A new pr-pass skill provides diagnostic and remediation guidance for failing PRs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
plugins/me/skills/create-pr/SKILL.md (1)
40-45: Add explicit exit-code branching to prevent unconditionalgh pr checks --watchexecution.The current snippet unconditionally runs
gh pr checks --watchafter verify, but the script returns different exit codes (0: done, 1: broken, 2: CI running). Only exit code 2 should trigger the watch command; exit 0 should proceed to auto-merge, and exit 1 should halt (useme:pr-pass).🔧 Proposed snippet refinement
# 6) verify -"${CLAUDE_PLUGIN_ROOT}/skills/create-pr/scripts/verify-pr-status.sh" -# exit 0: done -# exit 1: broken — use me:pr-pass -# exit 2: CI still running -gh pr checks --watch +VERIFY_EXIT=0 +"${CLAUDE_PLUGIN_ROOT}/skills/create-pr/scripts/verify-pr-status.sh" || VERIFY_EXIT=$? +# exit 0: done +# exit 1: broken — use me:pr-pass +# exit 2: CI still running +if [ "$VERIFY_EXIT" -eq 2 ]; then + gh pr checks --watch +fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@plugins/me/skills/create-pr/SKILL.md` around lines 40 - 45, The verify step currently unconditionally runs "gh pr checks --watch" after invoking "${CLAUDE_PLUGIN_ROOT}/skills/create-pr/scripts/verify-pr-status.sh"; change the flow to inspect the script's exit code from verify-pr-status.sh and branch: if the exit code is 2 then run "gh pr checks --watch", if it is 0 proceed to the auto-merge path, and if it is 1 stop and surface the failure (prompt use of me:pr-pass). Ensure you capture the exit code immediately after running verify-pr-status.sh and implement the conditional branching logic so only the exit-code-2 case triggers gh pr checks --watch.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@plugins/me/skills/pr-pass/SKILL.md`:
- Around line 19-24: The markdown has MD031 fence-spacing violations: ensure
every fenced code block (the triple-backtick blocks shown in SKILL.md) is
preceded and followed by a blank line; update each occurrence (the blocks
containing the bash examples and the proposed fixes) so there is exactly one
empty line above the opening ```bash and one empty line below the closing ```
(apply to the blocks at the noted sections and any similar blocks), then re-run
markdownlint/MD031 to confirm no remaining violations.
---
Nitpick comments:
In `@plugins/me/skills/create-pr/SKILL.md`:
- Around line 40-45: The verify step currently unconditionally runs "gh pr
checks --watch" after invoking
"${CLAUDE_PLUGIN_ROOT}/skills/create-pr/scripts/verify-pr-status.sh"; change the
flow to inspect the script's exit code from verify-pr-status.sh and branch: if
the exit code is 2 then run "gh pr checks --watch", if it is 0 proceed to the
auto-merge path, and if it is 1 stop and surface the failure (prompt use of
me:pr-pass). Ensure you capture the exit code immediately after running
verify-pr-status.sh and implement the conditional branching logic so only the
exit-code-2 case triggers gh pr checks --watch.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
plugins/me/skills/create-pr/SKILL.mdplugins/me/skills/create-pr/scripts/verify-pr-status.shplugins/me/skills/pr-pass/SKILL.md
| **CI failure** | ||
| ```bash | ||
| gh run view <run-id> --log-failed # read logs | ||
| # fix, commit, push | ||
| gh pr checks --watch | ||
| ``` |
There was a problem hiding this comment.
Fix markdownlint MD031 fence spacing violations.
Fenced code blocks should be surrounded by blank lines; current sections will keep triggering lint warnings.
🧹 Proposed markdown fix
**CI failure**
+
```bash
gh run view <run-id> --log-failed # read logs
# fix, commit, push
gh pr checks --watchFailing tests — run locally first, never fix blind
+
<test command>
# fix, commit, push
gh pr checks --watchConflict (DIRTY)
+
git fetch origin && git merge origin/<base>
# resolve, commit, pushBEHIND base
+
git fetch origin && git merge origin/<base-branch>
git push</details>
Also applies to: 26-31, 33-37, 39-43
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.21.0)</summary>
[warning] 20-20: Fenced code blocks should be surrounded by blank lines
(MD031, blanks-around-fences)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against the current code and only fix it if needed.
In @plugins/me/skills/pr-pass/SKILL.md around lines 19 - 24, The markdown has
MD031 fence-spacing violations: ensure every fenced code block (the
triple-backtick blocks shown in SKILL.md) is preceded and followed by a blank
line; update each occurrence (the blocks containing the bash examples and the
proposed fixes) so there is exactly one empty line above the opening bash and one empty line below the closing (apply to the blocks at the noted sections
and any similar blocks), then re-run markdownlint/MD031 to confirm no remaining
violations.
</details>
<!-- fingerprinting:phantom:poseidon:hawk -->
<!-- This is an auto-generated comment by CodeRabbit -->
# [5.37.0](v5.36.2...v5.37.0) (2026-02-26) ### Features * **skills:** add pr-pass skill and refactor create-pr workflow ([#540](#540)) ([28fe732](28fe732))
1 participant
Add
pr-passskill for fixing broken PRs, and refactorcreate-prto delegate repair work to it.Changes
me:pr-passon exit 1; addedgh pr checks --watchfor exit 2sync-with-base.shreference with directgit fetch && mergeinstructionTests
Manually verified skill content and script syntax.
Summary by CodeRabbit
New Features
Documentation