feat(eval-harness): add eval-harness skill for worktree-based code evaluation - #554
Conversation
📝 WalkthroughWalkthroughThis change introduces a comprehensive plan and complete scaffolding for a new eval-harness skill that compares two code variants using isolated git worktrees, parallel subagent evaluation, optional model grading, and standardized reporting. Includes documentation, test definitions, and cross-reference updates. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
tests/me/eval-harness.bats (1)
56-58: Minor redundancy in pattern.The
-iflag already makes the match case-insensitive, so"tie\|Tie"is redundant—"tie"alone suffices. Not a bug, just a nit.💡 Optional simplification
`@test` "eval-harness: skill documents tie as possible outcome" { - grep -qi "tie\|Tie" "$SKILL_FILE" + grep -qi "tie" "$SKILL_FILE" }🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tests/me/eval-harness.bats` around lines 56 - 58, In the test "eval-harness: skill documents tie as possible outcome" update the grep pattern used against $SKILL_FILE to remove the redundant alternation; since grep is invoked with -i, replace the pattern "tie\|Tie" with just "tie" so the case-insensitive match is sufficient and the test remains correct and simpler.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@tests/me/eval-harness.bats`:
- Around line 56-58: In the test "eval-harness: skill documents tie as possible
outcome" update the grep pattern used against $SKILL_FILE to remove the
redundant alternation; since grep is invoked with -i, replace the pattern
"tie\|Tie" with just "tie" so the case-insensitive match is sufficient and the
test remains correct and simpler.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 83d620a1-3b6e-4da8-8e34-35362f755304
📒 Files selected for processing (4)
docs/superpowers/plans/2026-03-16-eval-harness-skill.mdplugins/me/skills/eval-harness/SKILL.mdplugins/me/skills/eval/SKILL.mdtests/me/eval-harness.bats
# [5.45.0](v5.44.0...v5.45.0) (2026-03-16) ### Features * **eval-harness:** add eval-harness skill for worktree-based code evaluation ([#554](#554)) ([c093450](c093450))
Summary
Adds a new
me:eval-harnessskill that evaluates code changes or compares two implementations using isolated git worktrees and parallel subagents.Changes
plugins/me/skills/eval-harness/SKILL.md— new skill with worktree-based A/B evaluation (Phase 0: setup, Phase 1: parallel subagents, Phase 2: model grader/judge, Phase 3: structured report)tests/me/eval-harness.bats— 15 BATS tests covering all skill requirementsplugins/me/skills/eval/SKILL.md— added cross-reference pointing code eval use cases tome:eval-harnessdocs/superpowers/plans/2026-03-16-eval-harness-skill.md— implementation planTests
eval-harnesstests passBreaking
None — existing
me:evalskill unchanged (prompt A/B comparison).Summary by CodeRabbit
Documentation
Tests