Skip to content

feat(skills): sync ship-category skills with addyosmani upstream - #642

Merged
baleen37 merged 1 commit into
mainfrom
glossy-lagoon-dijkstra
May 10, 2026
Merged

feat(skills): sync ship-category skills with addyosmani upstream#642
baleen37 merged 1 commit into
mainfrom
glossy-lagoon-dijkstra

Conversation

@baleen37

@baleen37 baleen37 commented May 10, 2026

Copy link
Copy Markdown
Owner

Summary

  • Replace 5 ship-category skills under plugins/me/skills/ with the full upstream versions from addyosmani/agent-skills. Local versions had been heavily abridged (33-63 lines) and lost the upstream's strategic context — Common Rationalizations, Red Flags, Verification sections, and concrete templates (full ci.yml, ADR-001 template, deprecation notice, rollback runbook).
  • Remove two skills now subsumed by the richer upstream content: commit and project-setup.

Changes

Skill Before After
git-workflow-and-versioning 38 lines 300 lines
ci-cd-and-automation 33 lines 390 lines
deprecation-and-migration 46 lines 206 lines
documentation-and-adrs 58 lines 278 lines
shipping-and-launch 63 lines 309 lines
commit (existed) removed
project-setup (existed) removed

No conflicts with existing local assets — /ship, /verify, commit-guard.sh hook and its BATS tests are untouched and complementary to the new strategic skills.

Test plan

  • bats tests/ — 71/71 passing
  • No external references to removed commit/project-setup skills
  • Plugin manifest unaffected (skills auto-discovered via directory)

Summary by CodeRabbit

  • Documentation
    • Expanded CI/CD and automation skill documentation with GitHub Actions workflow examples and quality gate pipeline guidance
    • Enhanced deprecation-and-migration skill with detailed decision questionnaire and migration patterns
    • Updated documentation-and-adrs skill with comprehensive ADR templates and API documentation standards
    • Reorganized git-workflow-and-versioning skill with structured commit practices and branching conventions
    • Expanded shipping-and-launch skill with detailed pre-launch checklist, rollout sequencing, and rollback procedures
    • Removed commit and project-setup skill definitions

Review Change Stack

Replace 5 ship-category skills with full upstream versions from
addyosmani/agent-skills, and remove two skills that are now subsumed
by the richer upstream content:

- git-workflow-and-versioning (38 → 300 lines)
- ci-cd-and-automation (33 → 390 lines)
- deprecation-and-migration (46 → 206 lines)
- documentation-and-adrs (58 → 278 lines)
- shipping-and-launch (63 → 309 lines)
- remove: commit, project-setup
@baleen37
baleen37 enabled auto-merge (squash) May 10, 2026 05:54
@coderabbitai

coderabbitai Bot commented May 10, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f03ae8ef-0518-4f5c-af58-e2217d1c2062

📥 Commits

Reviewing files that changed from the base of the PR and between 5c005ff and 625deff.

📒 Files selected for processing (7)
  • plugins/me/skills/ci-cd-and-automation/SKILL.md
  • plugins/me/skills/commit/SKILL.md
  • plugins/me/skills/deprecation-and-migration/SKILL.md
  • plugins/me/skills/documentation-and-adrs/SKILL.md
  • plugins/me/skills/git-workflow-and-versioning/SKILL.md
  • plugins/me/skills/project-setup/SKILL.md
  • plugins/me/skills/shipping-and-launch/SKILL.md

📝 Walkthrough

Walkthrough

Seven skill documentation files were restructured and substantially expanded. Two skills (commit and project-setup) were entirely removed. The remaining five skills—CI/CD automation, deprecation/migration, documentation/ADRs, Git workflow, and shipping/launch—were expanded with detailed overviews, decision frameworks, structured workflows, concrete code examples, and verification checklists. Updates follow a consistent pattern: metadata, applicability guidance, core principles, step-by-step procedures, code templates, patterns/automation, and quality verification sections.

Changes

Skill Documentation Expansion and Consolidation

Layer / File(s) Summary
Deprecated Skills
plugins/me/skills/commit/SKILL.md, plugins/me/skills/project-setup/SKILL.md
Entire skill definitions removed, including frontmatter metadata and all workflow instructions.
Metadata Updates
plugins/me/skills/ci-cd-and-automation/SKILL.md, plugins/me/skills/deprecation-and-migration/SKILL.md, plugins/me/skills/documentation-and-adrs/SKILL.md, plugins/me/skills/git-workflow-and-versioning/SKILL.md, plugins/me/skills/shipping-and-launch/SKILL.md
Updated frontmatter descriptions with expanded, more specific language emphasizing enforcement, structured workflows, and decision frameworks.
Overview and Applicability
plugins/me/skills/**/SKILL.md
Expanded introductions with explicit "When to Use" and "When NOT to use" sections providing clear decision criteria for each skill.
Core Principles and Frameworks
plugins/me/skills/**/SKILL.md
Added trunk-based development guidance, Hyrum's Law, design-time planning, structured deprecation questionnaires, and deployment decision frameworks.
Workflows and Procedures
plugins/me/skills/**/SKILL.md
Step-by-step procedures for CI/CD quality gates, migration sequences, ADR workflows, branching strategies, save-point patterns, change summaries, feature flag strategies, and staged rollout timelines.
Git Commit and Workflow Details
plugins/me/skills/git-workflow-and-versioning/SKILL.md
Detailed atomic commit patterns with examples, descriptive message conventions with conventional commit types, concern separation rules, sizing guidance, branch naming, worktree usage, pre-commit hygiene automation, generated file handling, and debugging commands.
Migration Patterns and Automation
plugins/me/skills/**/SKILL.md
Migration patterns (Strangler, Adapter, Feature Flag), CI/CD automation beyond base CI (Dependabot/Renovate, Build Cop role), CI optimization tactics with caching/parallelism, and zombie code response guidance.
Code Examples and Templates
plugins/me/skills/**/SKILL.md
GitHub Actions workflows (basic, Postgres integration, E2E/Playwright), AI feedback templates, TypeScript JSDoc patterns, OpenAPI/Swagger snippets, Express error middleware, feature flag implementations, error-reporting flows, README structure, and changelog examples.
Quality Verification
plugins/me/skills/**/SKILL.md
Common rationalization vs. reality tables, comprehensive red-flag checklists for anti-patterns and risks, and detailed post-update verification checklists confirming gates, secrets, rollback mechanisms, and deployment readiness.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Poem

🐰 A rabbit hopped through docs with glee,
Expanding skills from brief to free,
With gates and checklists, clear and bright,
Each skill now shines with structured light,
Two skills retired, their duty done,
The rest now ready—migration won!

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch glossy-lagoon-dijkstra

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@baleen37
baleen37 merged commit bfeaac5 into main May 10, 2026
4 of 5 checks passed
@baleen37
baleen37 deleted the glossy-lagoon-dijkstra branch May 10, 2026 05:54
baleen-release-app Bot pushed a commit that referenced this pull request May 10, 2026
# [17.1.0](v17.0.0...v17.1.0) (2026-05-10)

### Features

* **skills:** sync ship-category skills with addyosmani upstream ([#642](#642)) ([bfeaac5](bfeaac5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant