fix(me): refine skill workflow guidance

[baleen37]

Summary

• Update create-pr guidance to use --body-file and avoid title/body command mixing.
• Simplify evolve guidance around index building, probe-based proposal flow, and dropped-skill diagnostics.
• Clarify QA scope handling for named environments/execution paths.

Tests

• bash tests/run-unit-tests.sh
• bash tests/run-all-tests.sh

Summary by CodeRabbit

• Documentation

  • Updated PR creation guidance for handling PR body content
  • Redesigned evolve skill with restructured workflow and proposal system
  • Updated QA skill requirements for environment and scope verification

• Refactor

  • Enhanced skill indexing capabilities

• Tests

  • Added tests for PR creation and skill verification

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8468311b-b559-4940-99da-14d98ff01429

📥 Commits

Reviewing files that changed from the base of the PR and between cbf3a88 and dafaf30.

📒 Files selected for processing (7)

• plugins/me/skills/create-pr/SKILL.md
• plugins/me/skills/evolve/SKILL.md
• plugins/me/skills/evolve/scripts/build-index.ts
• plugins/me/skills/qa/SKILL.md
• tests/me/create-pr-e2e.bats
• tests/me/evolve-build-index.bats
• tests/me/me-specific.bats

---

📝 Walkthrough

Walkthrough

Three independent me-skill updates: create-pr SKILL.md switches from inline --body to --body-file /tmp/pr_body.md with a matching e2e test; evolve SKILL.md is fully rewritten and build-index.ts gains DropReason, SignalSummary, formatRecentHeadline, and resolveSkillSessionPaths; qa SKILL.md adds two lines of scope-refinement guidance with a matching Bats test.

Changes

create-pr: --body-file instruction and test

Layer / File(s)	Summary
--body-file instruction and e2e test plugins/me/skills/create-pr/SKILL.md, tests/me/create-pr-e2e.bats	gh pr create is updated to use --body-file /tmp/pr_body.md; guidance is added that --title must not contain setup commands or body text; an e2e test asserts both the flag and the no-mixing guidance string.

evolve: build-index.ts signal/drop/session refactor and SKILL.md rewrite

Layer / File(s)	Summary
DropReason, RecentSkill, SignalSummary contracts plugins/me/skills/evolve/scripts/build-index.ts	Adds DropReason union type (stale | missing_current_body), optional drop_reason field on RecentSkill, and SignalSummary interface standardising the { signal, weight } return shape.
Signal computation and recent-index construction plugins/me/skills/evolve/scripts/build-index.ts	Replaces the signal-counting helper with summarizeSignal; adds formatRecentHeadline and dropReasonFor helpers; updates recent-index skill construction to compute body-hash match, per-body signal, drop_reason, and stale flags; switches mode recent headline to formatRecentHeadline.
resolveSkillSessionPaths and --skill entrypoint wiring plugins/me/skills/evolve/scripts/build-index.ts	Replaces skillSessionPaths with resolveSkillSessionPaths (exact-name-first with candidate fallback and noSkillSessions error path); --skill entrypoint filters index.skills by resolved skill names and sets headline via formatRecentHeadline.
evolve SKILL.md full rewrite plugins/me/skills/evolve/SKILL.md	Rewrites description, guardrails, Phase 0 Build Index, Phase 1 Scenario Probes + Proposal Subagent (with strict JSON output schema), and Phase 2 Approval and Apply (with external-cache diversion to upstream-suggestions.md and sequential git apply/per-patch commits).
Build-index test: updated drop-signal expectation tests/me/evolve-build-index.bats	Updates the dropped-skill signal assertion from dropped (stale) to dropped (missing_current_body) to match the new DropReason semantics.

qa: scope-refinement guidance and test

Layer / File(s)	Summary
Scope-refinement guidance and me-specific test plugins/me/skills/qa/SKILL.md, tests/me/me-specific.bats	Two lines are added to qa/SKILL.md requiring named verification environments or paths to be confirmed in scope before reporting; a new Bats test asserts the scope-refinement wording, Jenkins, and batch mentions.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• baleen37/bstack#681: Directly modifies the same build-index.ts and evolve-build-index.bats around --skill session resolution and dropped/stale vs missing_current_body signal logic.
• baleen37/bstack#675: Modifies build-index.ts and evolve SKILL.md around the --recent observed-bodies/hash-based freshness and staleness/drop handling.
• baleen37/bstack#601: Tied to the create-pr skill validation workflow, overlapping with the --body-file/--title e2e test changes in this PR.

Poem

🐇 Hoppity-hop through the diff we go,
--body-file keeps the title tidy and low,
Drop reasons renamed, signals weigh in with care,
QA scopes the Jenkins and batch paths with flair,
Each patch applied neatly, one commit at a time —
The warren of skills runs in elegant rhyme! 🌿

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch mellow-nebula-hopper

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}