Skip to content

feat(me): add upstream engineering skills - #754

Merged
baleen37 merged 1 commit into
mainfrom
feat/addd
Aug 7, 2026
Merged

feat(me): add upstream engineering skills#754
baleen37 merged 1 commit into
mainfrom
feat/addd

Conversation

@baleen37

@baleen37 baleen37 commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add upstream grilling, domain-modeling, grill-with-docs, code-review, to-tickets, research, and handoff skills.
  • Remove setup-matt-pocock-skills and all references to it.
  • Replace the previous bstack-specific research/handoff contracts while preserving research evaluator scripts and updating README/package structure.

Verification

  • bun run check:codex
  • bash tests/run-all-tests.sh
  • No setup-matt-pocock-skills references remain.
  • Upstream skill files were verified against the pinned source snapshot where unchanged.

Summary by CodeRabbit

  • New Features
    • Added skills for code review, domain modeling, documentation interviews, design grilling, and converting plans into implementation tickets.
    • Added guidance for architecture decision records and repository context documentation.
  • Improvements
    • Updated research to emphasize delegated, primary-source research with cited repository notes.
    • Simplified handoffs with temporary-file summaries, skill recommendations, sensitive-information redaction, and optional session focus.
    • Updated the plugin documentation to reflect the expanded skill set and workflows.
  • Documentation
    • Added implementation and design documentation for adopting the engineering skills.

@baleen37
baleen37 enabled auto-merge (squash) August 7, 2026 04:47
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: db67bdf0-4903-458d-8d4d-587c0582c44d

📥 Commits

Reviewing files that changed from the base of the PR and between 3fd9183 and 09c8e98.

📒 Files selected for processing (17)
  • docs/superpowers/plans/2026-08-07-adopt-matt-pocock-engineering-skills.md
  • docs/superpowers/specs/2026-08-07-adopt-matt-pocock-engineering-skills-design.md
  • plugins/me/README.md
  • plugins/me/skills/code-review/SKILL.md
  • plugins/me/skills/domain-modeling/ADR-FORMAT.md
  • plugins/me/skills/domain-modeling/CONTEXT-FORMAT.md
  • plugins/me/skills/domain-modeling/SKILL.md
  • plugins/me/skills/domain-modeling/agents/openai.yaml
  • plugins/me/skills/grill-with-docs/SKILL.md
  • plugins/me/skills/grilling/SKILL.md
  • plugins/me/skills/handoff/SKILL.md
  • plugins/me/skills/handoff/agents/openai.yaml
  • plugins/me/skills/research/SKILL.md
  • plugins/me/skills/research/agents/openai.yaml
  • plugins/me/skills/to-tickets/SKILL.md
  • tests/fixtures/handoff/compound-user-direction.md
  • tests/me/handoff-skill.bats

📝 Walkthrough

Walkthrough

This PR imports pinned Matt Pocock engineering skills into the me plugin, replaces research and handoff guidance, adds agent metadata, updates the README inventory, removes obsolete handoff tests and fixtures, and documents synchronization and verification steps.

Changes

Engineering skill adoption

Layer / File(s) Summary
Adoption scope and verification contract
docs/superpowers/specs/2026-08-07-adopt-matt-pocock-engineering-skills-design.md, docs/superpowers/plans/2026-08-07-adopt-matt-pocock-engineering-skills.md
The specification and plan define the pinned upstream source, skill packaging, replacement scope, synchronization rules, and verification commands.
Skill bundle implementation
plugins/me/skills/code-review/SKILL.md, plugins/me/skills/domain-modeling/*, plugins/me/skills/grill-with-docs/SKILL.md, plugins/me/skills/grilling/SKILL.md, plugins/me/skills/research/*, plugins/me/skills/to-tickets/SKILL.md, plugins/me/skills/handoff/*
The plugin adds new skills and agent metadata. The research and handoff workflows are replaced with updated instructions.
Plugin inventory and final validation
plugins/me/README.md, docs/superpowers/plans/2026-08-07-adopt-matt-pocock-engineering-skills.md, tests/me/handoff-skill.bats, tests/fixtures/handoff/compound-user-direction.md
The README lists the new skills and revised descriptions. The plan records generated-artifact checks and test suites. Obsolete handoff test coverage and its fixture are removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • baleen37/bstack#723: Both changes replace the handoff workflow and remove the same obsolete handoff test and fixture.
  • baleen37/bstack#699: Both changes redefine plugins/me/skills/research/SKILL.md.
  • baleen37/bstack#634: Both changes add the grilling-based design interview workflow to the me plugin.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/addd

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@baleen37
baleen37 merged commit 49ddfd3 into main Aug 7, 2026
3 of 4 checks passed
@baleen37
baleen37 deleted the feat/addd branch August 7, 2026 04:47
baleen-release-app Bot pushed a commit that referenced this pull request Aug 7, 2026
# [17.42.0](v17.41.6...v17.42.0) (2026-08-07)

### Features

* **me:** add upstream engineering skills ([#754](#754)) ([49ddfd3](49ddfd3))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant