chore: remove unused CI FEATURES build-arg and dedupe compose image build#1121
Open
crazywriter1 wants to merge 1 commit into
Open
chore: remove unused CI FEATURES build-arg and dedupe compose image build#1121crazywriter1 wants to merge 1 commit into
crazywriter1 wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FEATURESbuild-arg from PR and release Docker workflows. TheDockerfiledoes not declareARG FEATURES, andcargo builddoes not pass--features, so the matrix values had no effect (leftover from an older client layout).executionbuildsbase-node:local, andnodereuses the same image instead of running a second identical build.Motivation
CI suggested feature flags were being applied when they were not. Locally,
docker compose up --buildcompiled the same Dockerfile twice forexecutionandnode, doubling build time without changing runtime behavior.Changes
.github/workflows/pr.yml— removefeaturesmatrix field andbuild-args: FEATURES=....github/workflows/docker.yml— samedocker-compose.yml— addimage: base-node:localto both services; keepbuildonly onexecutionTest plan
buildonexecution, sharedbase-node:localimage)FEATURESbuild-argdocker compose config/docker compose build— skipped locally (Docker not installed in WSL)